From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] build: ruby: Rewrite build system to use gem archives. Date: Tue, 18 Aug 2015 08:40:23 +0200 Message-ID: <87lhd9nlpk.fsf@elephly.net> References: <87d1zcfmyn.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRaZX-00054m-IK for guix-devel@gnu.org; Tue, 18 Aug 2015 02:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRaZT-0004Tn-CY for guix-devel@gnu.org; Tue, 18 Aug 2015 02:40:35 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:25621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRaZT-0004TE-5Q for guix-devel@gnu.org; Tue, 18 Aug 2015 02:40:31 -0400 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel Thompson, David writes: >> The major change from the previous version of this patch is that I >> figured how to unpack the source gem, allow the package build script >> to make any necessary dynamic patches, and then install a repacked gem >> as opposed to the source gem. > > I found a problem with this system when it came to running certain > test suites that used Bundler to read the gemspec. A lot of upstream > gemspec include things like shell commands to run 'git ls-files' and > things. In the former build system, the 'gitify' phase took care of > this. Now, we can more easily deal with it by asking the 'gem' > utility to generate a gemspec for us based on the source gem archive. > Hope that wasn't too confusing for the non-Rubyists. I just read through the patch set. Looks good! (Note: I haven’t actually tested this yet.) It seems that you had to disable tests for “useragent”, “arel”, “git”; I assume that’s because the gems do not come with the necessary test files. I remember a link to a discussion you once shared, in which it was said that the declaration of test files in gemspec manifests is deprecated. Do you think the absence of tests in the published gems is going to be a problem for many more packages? ~~ Ricardo