[PATCH] gnu: Add cabal-install.

[PATCH] gnu: Add cabal-install.

[Siniša Biđin]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-cabal-install.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-cabal-install.patch, Size: 1818 bytes --]

From 0d321519e9bce55956b2989c7814e36a9abe9421 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sini=C5=A1a=20Bi=C4=91in?= <sinisa@bidin.eu>
Date: Tue, 18 Aug 2015 16:19:11 +0200
Subject: [PATCH] gnu: Add cabal-install.

* gnu/packages/haskell.scm (cabal-install): New variable.
---
 gnu/packages/haskell.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33eb1b5..b7a889e 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -238,6 +238,38 @@
 interactive environment for the functional language Haskell.")
     (license bsd-3)))
 
+(define-public cabal-install
+  (package
+    (name "cabal-install")
+    (version "1.18.1.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri
+         (string-append
+          "http://hackage.haskell.org/package/cabal-install/cabal-install-"
+          version
+          ".tar.gz"))
+        (sha256
+         (base32 "1r1shhvnpgxf91rmbv3wa1rkd24plbgr6bpz3aj80ir0z3zbdayn"))))
+    (arguments `(#:tests? #f))
+    (build-system haskell-build-system)
+    (propagated-inputs
+      `(("ghc-http" ,ghc-http)
+        ("ghc-mtl" ,ghc-mtl)
+        ("ghc-network-uri" ,ghc-network-uri)
+        ("ghc-network" ,ghc-network)
+        ("ghc-random" ,ghc-random)
+        ("ghc-stm" ,ghc-stm)
+        ("ghc-zlib" ,ghc-zlib)))
+    (home-page "http://www.haskell.org/cabal/")
+    (synopsis "The command-line interface for Cabal and Hackage.")
+    (description
+      "The cabal command-line program simplifies the process of managing
+Haskell software by automating the fetching, configuration, compilation and
+installation of Haskell libraries and programs.")
+    (license bsd-3)))
+
 (define-public ghc-mtl
   (package
     (name "ghc-mtl")
-- 
2.4.3

Re: [PATCH] gnu: Add cabal-install.

[Ludovic Courtès]

Siniša Biđin <sinisa@bidin.eu> skribis:

> From 0d321519e9bce55956b2989c7814e36a9abe9421 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Sini=C5=A1a=20Bi=C4=91in?= <sinisa@bidin.eu>
> Date: Tue, 18 Aug 2015 16:19:11 +0200
> Subject: [PATCH] gnu: Add cabal-install.
>
> * gnu/packages/haskell.scm (cabal-install): New variable.

[...]

> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm

Please add a copyright line for yourself.

> +    (arguments `(#:tests? #f))

Could you add a comment above explaining why tests are disabled?  (We
generally avoid that unless there’s a good reason, sometimes because
running the tests would be unnecessarily complex.)

> +    (synopsis "The command-line interface for Cabal and Hackage.")

Remove “The” and the period (and make sure to run ‘guix lint’ ;-)).

Otherwise LGTM.

Could you send an updated patch?

Thanks,
Ludo’.

Re: [PATCH] gnu: Add cabal-install.

[Siniša Biđin]

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

On 2015-08-25 23:27, ludo@gnu.org wrote:
> Please add a copyright line for yourself.

Added.

>> +    (arguments `(#:tests? #f))
> 
> Could you add a comment above explaining why tests are disabled?  (We
> generally avoid that unless there’s a good reason, sometimes because
> running the tests would be unnecessarily complex.)

I've added a simple "FIXME" comment to that line, similar to how the
other haskell.scm packages do it. The reason is that the ghc-* libs
needed to enable testing haven't been imported yet. I've attempted to
fix that, but got tangled up in conflicting dependency versions and
gave up for now.

>> +    (synopsis "The command-line interface for Cabal and Hackage.")
> 
> Remove “The” and the period (and make sure to run ‘guix lint’ ;-)).

Also fixed.

> Could you send an updated patch?

Sure, you'll find it attached.

Thanks,

Siniša

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-cabal-install.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-cabal-install.patch, Size: 2047 bytes --]

From a8e3990be14e4259e7e8beeeacef744cee7e6cae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sini=C5=A1a=20Bi=C4=91in?= <sinisa@bidin.eu>
Date: Tue, 18 Aug 2015 16:19:11 +0200
Subject: [PATCH] gnu: Add cabal-install.

* gnu/packages/haskell.scm (cabal-install): New variable.
---
 gnu/packages/haskell.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33eb1b5..f866c1d 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
+;;; Copyright © 2015 Siniša Biđin <sinisa@bidin.eu>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -238,6 +239,37 @@
 interactive environment for the functional language Haskell.")
     (license bsd-3)))
 
+(define-public cabal-install
+ (package
+  (name "cabal-install")
+   (version "1.18.1.0")
+   (source
+    (origin
+     (method url-fetch)
+      (uri (string-append
+            "http://hackage.haskell.org/package/cabal-install/cabal-install-"
+            version
+            ".tar.gz"))
+      (sha256
+       (base32 "1r1shhvnpgxf91rmbv3wa1rkd24plbgr6bpz3aj80ir0z3zbdayn"))))
+   (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
+   (build-system haskell-build-system)
+   (propagated-inputs
+    `(("ghc-http" ,ghc-http)
+      ("ghc-mtl" ,ghc-mtl)
+      ("ghc-network-uri" ,ghc-network-uri)
+      ("ghc-network" ,ghc-network)
+      ("ghc-random" ,ghc-random)
+      ("ghc-stm" ,ghc-stm)
+      ("ghc-zlib" ,ghc-zlib)))
+   (home-page "http://www.haskell.org/cabal/")
+   (synopsis "Command-line interface for Cabal and Hackage")
+   (description
+    "The cabal command-line program simplifies the process of managing
+Haskell software by automating the fetching, configuration, compilation and
+installation of Haskell libraries and programs.")
+   (license bsd-3)))
+
 (define-public ghc-mtl
   (package
     (name "ghc-mtl")
-- 
2.5.0

Re: [PATCH] gnu: Add cabal-install.

[Ludovic Courtès]

Siniša Biđin <sinisa@bidin.eu> skribis:

> On 2015-08-25 23:27, ludo@gnu.org wrote:

[...]

>>> +    (arguments `(#:tests? #f))
>>
>> Could you add a comment above explaining why tests are disabled?  (We
>> generally avoid that unless there’s a good reason, sometimes because
>> running the tests would be unnecessarily complex.)
>
> I've added a simple "FIXME" comment to that line, similar to how the
> other haskell.scm packages do it. The reason is that the ghc-* libs
> needed to enable testing haven't been imported yet. I've attempted to
> fix that, but got tangled up in conflicting dependency versions and
> gave up for now.

Fair enough.

> Sure, you'll find it attached.

Applied, thanks!

Ludo’.