From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cabal-install.
Date: Tue, 25 Aug 2015 23:27:06 +0200
Message-ID: <87lhczf49h.fsf@gnu.org>
References: <bf91f9b5aadf0108a705df4aa434bad0@bidin.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZULkU-0003nL-6E
	for guix-devel@gnu.org; Tue, 25 Aug 2015 17:27:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZULkT-0001ms-08
	for guix-devel@gnu.org; Tue, 25 Aug 2015 17:27:17 -0400
In-Reply-To: <bf91f9b5aadf0108a705df4aa434bad0@bidin.eu> (=?utf-8?Q?=22Sin?=
	=?utf-8?Q?i=C5=A1a_Bi=C4=91in=22's?=
	message of "Tue, 18 Aug 2015 16:32:38 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?U2luacWhYSBCacSRaW4=?= <sinisa@bidin.eu>
Cc: guix-devel@gnu.org

Sini=C5=A1a Bi=C4=91in <sinisa@bidin.eu> skribis:

> From 0d321519e9bce55956b2989c7814e36a9abe9421 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Sini=3DC5=3DA1a=3D20Bi=3DC4=3D91in?=3D <sinisa@bidin.eu>
> Date: Tue, 18 Aug 2015 16:19:11 +0200
> Subject: [PATCH] gnu: Add cabal-install.
>
> * gnu/packages/haskell.scm (cabal-install): New variable.

[...]

> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm

Please add a copyright line for yourself.

> +    (arguments `(#:tests? #f))

Could you add a comment above explaining why tests are disabled?  (We
generally avoid that unless there=E2=80=99s a good reason, sometimes because
running the tests would be unnecessarily complex.)

> +    (synopsis "The command-line interface for Cabal and Hackage.")

Remove =E2=80=9CThe=E2=80=9D and the period (and make sure to run =E2=80=98=
guix lint=E2=80=99 ;-)).

Otherwise LGTM.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.