From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 5/6] guix: Move package-transitive-propagated-labels* and
	package-propagated-input-refs to (guix packages).
Date: Wed, 09 Sep 2015 22:24:11 +0200
Message-ID: <87lhcfqr2s.fsf@gnu.org>
References: <1436488689-4078-1-git-send-email-ericbavier@openmailbox.org>
	<1436488689-4078-5-git-send-email-ericbavier@openmailbox.org>
	<20150721211143.6edeaae7@openmailbox.org> <87io9cba7o.fsf@gnu.org>
	<20150908033158.16a45fec@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZZlun-00007q-4u
	for guix-devel@gnu.org; Wed, 09 Sep 2015 16:24:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZZlum-0007vM-7S
	for guix-devel@gnu.org; Wed, 09 Sep 2015 16:24:21 -0400
In-Reply-To: <20150908033158.16a45fec@openmailbox.org> (Eric Bavier's message
	of "Tue, 8 Sep 2015 03:31:58 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

Eric Bavier <ericbavier@openmailbox.org> skribis:

> I find myself needing this functionality while exploring configuration
> support in xmonad, so I am (finally) revisiting this patch.

Nice!

> For Perl, my idea is to wrap each module somehow, so that perl gets the
> appropriate 'use lib "/gnu/store/..."' when it loads each module.
> Preferably the solution would also work with store deduplication.
> I've not yet confirmed this is even feasible, so anyone with more perl
> knowledge should chime in.
>
> Our haskell modules install files into a "package.conf.d" subdirectory,
> and these files actually keep references to all haskell modules that
> were configured in the environment when it was built.  I'm baffled why
> GHC does not make use of this information for dependency resolution when
> it loads libraries.  Perhaps we could hack our GHC to do so.

This sounds like retrofitting some RUNPATH-like functionality in
languages.  This would be ideal, and we should use whatever already
exists if that does the job (which seems to be the case for Perl?).

Otherwise we should really push upstream to implement that
functionality.

> From c7932475b95f22f891169b7f315366e2602fb4f5 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Tue, 21 Jul 2015 20:45:54 -0500
> Subject: [PATCH 5/6] guix: packages: Add transitive-input-references.
>
> * guix/packages.scm (transitive-input-references): New procedure.
> * gnu/packages/version-control.scm (package-transitive-propagated-labels*)
>   (package-propagated-input-refs): Delete.
>   (git)[arguments]: Adjust to transitive-input-references.

It addresses previous comments and looks reasonable to me.

OK for =E2=80=98master=E2=80=99!

Thank you,
Ludo=E2=80=99.