From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Wed, 21 Oct 2015 22:12:26 +0200
Message-ID: <87lhawrnf9.fsf@denknerd.org>
References: <1445261129-27744-1-git-send-email-paul@denknerd.org>
	<87si546mbn.fsf@gnu.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZozkX-0006Ty-5u
	for guix-devel@gnu.org; Wed, 21 Oct 2015 16:12:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZozkT-0007Pl-0t
	for guix-devel@gnu.org; Wed, 21 Oct 2015 16:12:40 -0400
In-reply-to: <87si546mbn.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org


On 2015-10-21 at 21:41, quoth Ludovic Court=C3=A8s:
>> +    (name "dosbox")
>> +    (version "0.74")
>
> Rather 0.74.svn3947 or similar.

Right, fixed.

>> +              ;; Using SVN head, since the last release (2010) is inc=
ompatible
>> +              ;; with GCC5 (see
>> +              ;; <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D=
624976>).
>
> Sure, but we=E2=80=99re currently building with GCC 4.9.  :-)  Anyway, =
we=E2=80=99ll have
> the problem sooner or later, so this is probably wise.

I've fixed the comment.  IIUC it's actually a problem with GCC 4.8+, but
anyway :).

>> +    (description "DOSBox is a DOS-emulator that uses the SDL-library.=
  DOSBox
>
> =E2=80=9Cthe SDL library=E2=80=9D

Done.

>> +    (license license:gpl3)))
>
> According to dosbox-0.74.tar.gz, it=E2=80=99s GPLv2+, not GPLv3-only.  =
Could you
> double check?

You're right, fixed.

Cheers,
p.