all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/3] emacs: Improve post processing of popup arguments.
Date: Thu, 12 Nov 2015 21:24:38 +0300	[thread overview]
Message-ID: <87lha3qdnd.fsf@gmail.com> (raw)
In-Reply-To: 87wptsyyxm.fsf@gnu.org

Ludovic Courtès (2015-11-09 00:16 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Hello, this patchset is for adjusting "M-x guix" for the recent
>> environment/container changes.  'magit-popup' returns a simple list of
>> arguments, and this list needs to be "post-processed".  Previously a
>> very simple post-processing (moving the rest "-- ..." arguments to the
>> end of the arg list) was enough, but now (for a rather complicated 'guix
>> environment' command: positional "--ad-hoc", shell command after '--')
>> it should be improved.  So this is the improvement.
>
> Good catch.
>
>> [PATCH 1/3] emacs: Improve post processing of popup arguments.
>> [PATCH 2/3] emacs: Adjust 'guix container' popup.
>> [PATCH 3/3] emacs: Adjust 'guix environment' popup.
>
> On a cursory look it LGTM.  I don’t grasp the details of #1 but I
> trust you.

OK, thanks, I forgot the details of #1 already :-)  The point was to
make a general final processing of arguments (returned by magit-popup).

> Thank you!

And thank you!  Pushed.

-- 
Alex

      reply	other threads:[~2015-11-12 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  8:39 [PATCH 0/3] emacs: Improve post processing of popup arguments Alex Kost
2015-11-05  8:39 ` [PATCH 1/3] " Alex Kost
2015-11-05  8:39 ` [PATCH 2/3] emacs: Adjust 'guix container' popup Alex Kost
2015-11-05  8:39 ` [PATCH 3/3] emacs: Adjust 'guix environment' popup Alex Kost
2015-11-08 21:16 ` [PATCH 0/3] emacs: Improve post processing of popup arguments Ludovic Courtès
2015-11-12 18:24   ` Alex Kost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lha3qdnd.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.