Re: [PATCH 2/3] gnu: Add go-1.4.

[ludo@gnu.org (Ludovic Courtès)]

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/golang.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add golang.scm.

[...]

> +        (replace 'build
> +          (let* ((bash   (assoc-ref %build-inputs "bash"))
> +                 (gccgo  (assoc-ref %build-inputs "gccgo"))
> +                 (output (assoc-ref %outputs "out")))
> +            (setenv "CC" "gcc")
> +            (setenv "GOROOT" (getcwd))
> +            (setenv "GOROOT_BOOTSTRAP" gccgo)
> +            (setenv "GOROOT_FINAL" output)
> +            (setenv "CGO_ENABLED" "0")
> +            (lambda _
> +              ;; all.bash includes the tests, which fail because they require
> +              ;; network access, and access to /bin
> +              (zero? (system* (string-append bash "/bin/bash") "make.bash")))))

Why not:

  (replace 'build
    (lambda* (#:key inputs #:allow-other-keys)
      (let ((bash …) …)
        …
        (zero? (system* …)))))

?

> +    (synopsis "Compiled, statically typed language developed by Google")
> +    (description "Go, also commonly referred to as golang, is a programming
> + language developed at Google.  Designed primarily for systems programming, it
> + is a compiled, statically typed language in the tradition of C and C++, with
> +garbage collection, various safety features and CSP-style concurrent programming
> +features added.")

I would remove “developed by Google” and focus on the technical
characteristics.

Also, what’s CSP-style?  :-)

Thanks!

Ludo’.