From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/04] gnu: xdotools: Update to 3.20150503.1
Date: Sat, 06 Feb 2016 15:39:25 -0800 [thread overview]
Message-ID: <87lh6xtnnm.fsf@dustycloud.org> (raw)
In-Reply-To: <20160206211853.GA6912@jasmine>
Leo Famulari writes:
> On Sat, Feb 06, 2016 at 11:48:13AM -0800, Christopher Allan Webber wrote:
>> Leo Famulari writes:
>> > On Fri, Feb 05, 2016 at 07:48:12PM -0800, Christopher Allan Webber wrote:
>> > Is this line too long? I can't say for sure looking at the patch in my
>> > email client. If so, the linter should complain.
>> >
>> > [...]
>>
>> You're right. I should be using the linter but I was slacking off I
>> guess... sorry!
>
> The linter is our friend and we should visit him or her often :)
I agree. I'll try to be more familiar with our linter friend more often!
> I do wonder about the tests... if the required "black magic" is having
> an X server available, we do have some examples of that in the package
> tree. Otherwise it might be good to explain a little more so that it's
> easier for future contributors to understand what the problem is.
>
> Otherwise LGTM.
Ah well... I didn't write this part about the tests! And I don't know
the context. I mostly just patched things up for the new version.
Anyway, since you say "LGTM", I'm going to merge this one.
prev parent reply other threads:[~2016-02-06 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 3:48 [PATCH 02/04] gnu: xdotools: Update to 3.20150503.1 Christopher Allan Webber
2016-02-06 8:35 ` Leo Famulari
2016-02-06 19:48 ` Christopher Allan Webber
2016-02-06 21:18 ` Leo Famulari
2016-02-06 23:39 ` Christopher Allan Webber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh6xtnnm.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.