From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: [PATCH] gnu: Add laby. Date: Sat, 13 Feb 2016 14:08:40 +0100 Message-ID: <87lh6oahbb.fsf@gnu.org> References: <87egcleiig.fsf@gnu.org> <87fux1y0vg.fsf@dustycloud.org> <20160211221839.73cf23b5@debian-netbook> <87k2madh1x.fsf@gnu.org> <20160212181333.GB8954@debian> <878u2pbqwr.fsf@gnu.org> <20160213082032.GA6239@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUZwY-0002AB-BJ for guix-devel@gnu.org; Sat, 13 Feb 2016 08:08:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUZwV-00073r-6W for guix-devel@gnu.org; Sat, 13 Feb 2016 08:08:58 -0500 In-Reply-To: <20160213082032.GA6239@debian> (Andreas Enge's message of "Sat, 13 Feb 2016 09:20:32 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: > "git am" complained about whitespace issues with tabs, but I suppose these > are okay in make files :-) :-) >> + (inputs >> + `(("camlp4" ,camlp4) >> + ("m4" ,m4) >> + ("ocaml" ,ocaml))) > > I think all of these should be native-inputs; the first two are not refer= enced > in the result ("guix gc --references /gnu/store/..."), and ocaml is defin= itely > needed during compile time. I moved them and pushed the patch. Thanks! guix gc --reference is useful next to lint. Greetings, Jan --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.nl= =20=20