From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 6/7] gnu: irssi: Use 'modify-phases'. Date: Sun, 28 Feb 2016 16:48:54 +0100 Message-ID: <87lh64dee1.fsf@elephly.net> References: <1456654212-31881-1-git-send-email-efraim@flashner.co.il> <1456654212-31881-7-git-send-email-efraim@flashner.co.il> <20160228143202.GF18720@solar> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa3ao-00047E-CD for guix-devel@gnu.org; Sun, 28 Feb 2016 10:49:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aa3ak-0000Tm-BS for guix-devel@gnu.org; Sun, 28 Feb 2016 10:49:10 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:25214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa3ak-0000TE-3Q for guix-devel@gnu.org; Sun, 28 Feb 2016 10:49:06 -0500 In-reply-to: <20160228143202.GF18720@solar> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: > ... > > On Sun, Feb 28, 2016 at 12:10:11PM +0200, Efraim Flashner wrote: >> * gnu/packages/irc.scm (irssi)[arguments]: Use 'modify-phases'. > > Nothing to say. I think it could be combined with the previous commit, > but this is also not a problem. > > ... I think it is good to keep syntax changes separate in general, but in this case there doesn’t seem to be much value as the whole expression is changed anyway (due to the move to a different module). I still have a slight preference to keep the commit separate, though. ~~ Ricardo