From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: xfce: =?utf-8?Q?Don=E2=80=99t?= wrap startxfce4.
	(Re: Xfce collision)
Date: Tue, 01 Mar 2016 22:26:45 +0100
Message-ID: <87lh61nb3e.fsf@gnu.org>
References: <20160225203658.GA24846@solar> <87ziujj43y.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aaroj-0000d9-Gm
	for guix-devel@gnu.org; Tue, 01 Mar 2016 16:26:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aaroe-0005Zm-K9
	for guix-devel@gnu.org; Tue, 01 Mar 2016 16:26:53 -0500
In-Reply-To: <87ziujj43y.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?=
	=?utf-8?B?cw==?= message of "Mon, 29 Feb 2016 16:46:41 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> Andreas Enge <andreas@enge.fr> writes:
>
>> Hello,
>>
>> when installing xfce, there is a collision with xfce4-session for the fi=
le
>> startxfce4.
>>
>> The reason is the following:
>>        (alist-replace
>>         'install
>>         (lambda* (#:key outputs #:allow-other-keys)
>>           (let* ((out  (assoc-ref outputs "out"))
>>                  (bin  (string-append out "/bin"))
>>                  (prog (string-append bin "/startxfce4")))
>>             (mkdir-p bin)
>>             (symlink (string-append
>>                       (assoc-ref %build-inputs "xfce4-session")
>>                       "/bin/startxfce4")
>>                      prog)
>>             (wrap-program prog
>>               ;; For xfce4-panel plugins.
>>               `("X_XFCE4_LIB_DIRS" =3D ,(list (getenv "X_XFCE4_LIB_DIRS"=
))))))
>>     (propagated-inputs
>>      ...
>>        ("xfce4-session"        ,xfce4-session)
>>
>> So if I understand correctly, the startxfce4 of xfce will end up being a
>> wrapped version of the one in xfce4-session. However, if both are instal=
led,
>> could it not be possible that the non-wrapped version ends up in the pro=
file?
> When only the =E2=80=98xfce=E2=80=99 package is installed, the wrapped ve=
rsion is used.
> I don=E2=80=99t know what will happen when both =E2=80=98xfce=E2=80=99 an=
d =E2=80=98xfce4-session=E2=80=99 are
> installed to a profile.
>
> This package was introduced before the =E2=80=98etc/profile=E2=80=99 wher=
e enviroment
> variables from search-paths are set.  So, the wrapper is redundant now.

The wrapper would still be useful when it=E2=80=99s not installed in a prof=
ile
(for instance, when running $(guix build xfce4)/bin/startxfce4), but
that=E2=80=99s probably not a use case worth supporting in this case.  Thou=
ghts?

> From 6f6ba4e8c347770b279e9344ba49bf305cd41da8 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@gmail.com>
> Date: Mon, 29 Feb 2016 14:57:56 +0800
> Subject: [PATCH] gnu: xfce: Don't wrap 'startxfce4'.
>
> The necessary environment variables are set by 'etc/profile' now.
>
> * gnu/packages/xfce.scm (xfce)[build-system]: Use 'trivial-build-system'.
> [arguments]: Simplify.

Otherwise the patch LGTM.

Thanks,
Ludo=E2=80=99.