From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: FIXUP: [PATCH 01/10] gnu: cross: Use CROSS_*_INCLUDE_PATH for system headers. Date: Sat, 14 May 2016 22:50:36 +0200 Message-ID: <87lh3c9xer.fsf@drakenvlieg.flower> References: <1461942751-23883-1-git-send-email-janneke@gnu.org> <87vb2h2onq.fsf@netris.org> <87zirtcfgn.fsf@drakenvlieg.flower> <87vb2hcahb.fsf_-_@drakenvlieg.flower> <87vb2g4d8g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1gbX-0003mH-BR for guix-devel@gnu.org; Sat, 14 May 2016 16:56:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1gbU-0003mZ-1P for guix-devel@gnu.org; Sat, 14 May 2016 16:56:07 -0400 In-Reply-To: <87vb2g4d8g.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 14 May 2016 22:05:19 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > Thanks for your quick response, applied with an adjusted commit log. Thanks. > I concur with Mark: this is a very sensitive area that takes time to > test and adjust, which is the main reason why it takes me so much time > to review and such ;-), so we want to make sure we don=E2=80=99t break it. Sure, I agree. These two real silly problems I introduced only makes me appreciate more that it takes some time to get the patches in ;-) > In the future, please make sure to test individual patches with the > known-good *-linux-gnu targets. Yes. I wrongly assumed (though that I knew and saw happen) that cross-gcc and cross-libc were used in the bootstrap process that I was thus testing them...I've seen a lot of my build host compilers and libc getting built and rebuilt. Now I know that's not the case and need to test for that when touching this area. That's still no excuse for not testing the cross-base.scm patches individually :-/ I would still like to explore getting rid of the patched gcc and all the environment variables and use a --sysroot instead; but I would need some help/inspiration to get that experiment going. Greetings, Jan --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.nl= =20=20