From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/7] import cran: Remove more invalid characters from
	package names.
Date: Mon, 30 May 2016 10:48:36 +0200
Message-ID: <87lh2s9biz.fsf@gnu.org>
References: <1464018008-1767-1-git-send-email-ricardo.wurmus@mdc-berlin.de>
	<1464018008-1767-2-git-send-email-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b7IsO-0000jP-1k
	for guix-devel@gnu.org; Mon, 30 May 2016 04:48:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b7IsJ-0002iv-SP
	for guix-devel@gnu.org; Mon, 30 May 2016 04:48:43 -0400
In-Reply-To: <1464018008-1767-2-git-send-email-ricardo.wurmus@mdc-berlin.de>
	(Ricardo Wurmus's message of "Mon, 23 May 2016 17:40:02 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> * guix/import/cran.scm (guix-name): Replace period and underscore with
>   dash; always prepend package names with "r-".

[...]

> +    (string-append "r-" (string-downcase
> +                         (regexp-substitute/global #f "(_|\\.)" name
> +                                                   'pre "-" 'post))))

I have a preference fro =E2=80=98string-map=E2=80=99, which I find more rea=
dable than
=E2=80=98regexp-substitute/global=E2=80=99 in simple cases.  Thoughts?

Otherwise LGTM!

Thanks,
Ludo=E2=80=99.