From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/8] gnu: qt: Update to 5.6.1-1.
Date: Fri, 29 Jul 2016 21:20:48 +0200
Message-ID: <87lh0kxncf.fsf@gnu.org>
References: <20160729082357.17501-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bTDL6-00028R-SN
	for guix-devel@gnu.org; Fri, 29 Jul 2016 15:20:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bTDL3-0005cK-Mp
	for guix-devel@gnu.org; Fri, 29 Jul 2016 15:20:56 -0400
In-Reply-To: <20160729082357.17501-1-david@craven.ch> (David Craven's message
	of "Fri, 29 Jul 2016 10:23:50 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/qt.scm (qt): Update to 5.6.1-1.

I think there are 3 patches here: the update, the switch to
=E2=80=98modify-phases=E2=80=99, and the thing that disables examples.  Cou=
ld you
separate them?

> +       (modify-phases %standard-phases
> +         (add-after 'configure 'patch-bin-sh
> +           (lambda _
> +             (substitute* '("qtbase/config.status"
> +                            "qtbase/configure"
> +                            "qtbase/mkspecs/features/qt_functions.prf"
> +                            "qtbase/qmake/library/qmakebuiltins.cpp")
> +                          (("/bin/sh") (which "sh")))
                             ^
This should be aligned with the =E2=80=98u=E2=80=99 of =E2=80=98substitute*=
=E2=80=99.

It seems like these substitutions could be added to the existing ones
int the =E2=80=98configure=E2=80=99 phase.

Otherwise LGTM.

Could you send updated patches?

Thank you!

Ludo=E2=80=99.