From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add squeak-vm
Date: Tue, 30 Aug 2016 12:02:32 +0200
Message-ID: <87lgzeo9qf.fsf@gnu.org>
References: <87oa4h277j.fsf@saiph.selenimh> <87oa4gyo8s.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1befsQ-00024v-QV
	for guix-devel@gnu.org; Tue, 30 Aug 2016 06:02:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1befsK-0005u6-Qq
	for guix-devel@gnu.org; Tue, 30 Aug 2016 06:02:41 -0400
In-Reply-To: <87oa4gyo8s.fsf@saiph.selenimh> (Nicolas Goaziou's message of
	"Fri, 26 Aug 2016 09:37:39 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: guix-devel@gnu.org

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> From 5d0d8f39c0d4ef1c857421da64e6bab2bc07d852 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Wed, 24 Aug 2016 22:58:44 +0200
> Subject: [PATCH 2/2] gnu: Add squeak-vm
>
> * gnu/packages/smalltalk.scm (squeak-vm): New variable.

Applied with minor changes:

> +    (native-inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("dbus" ,dbus)
> +       ("freetype" ,freetype)
> +       ("libffi" ,libffi)
> +       ("libiconv" ,libiconv)
> +       ("libxrender" ,libxrender)
> +       ("mesa" ,mesa)
> +       ("pkg-config" ,pkg-config)
> +       ("pulseaudio" ,pulseaudio)))

Only =E2=80=98pkg-config=E2=80=99 needs to be native input, and libiconv ca=
n be omitted.

> +    (synopsis "Implementation of the Smalltalk programming language
> +and environment")

Removed =E2=80=9CImplementation of the=E2=80=9D.

I added a phase to remove PATH=3D/usr/bin in bin/squeak{,.sh}.

I also added a copyright line for you.

The next commit makes builds reproducible by removing timestamps from
the binaries.

Please let me know if anything is amiss!

Thanks,
Ludo=E2=80=99.