Re: [PATCH] Add squeak-vm

[ludo@gnu.org (Ludovic Courtès)]

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> From 5d0d8f39c0d4ef1c857421da64e6bab2bc07d852 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Wed, 24 Aug 2016 22:58:44 +0200
> Subject: [PATCH 2/2] gnu: Add squeak-vm
>
> * gnu/packages/smalltalk.scm (squeak-vm): New variable.

Applied with minor changes:

> +    (native-inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("dbus" ,dbus)
> +       ("freetype" ,freetype)
> +       ("libffi" ,libffi)
> +       ("libiconv" ,libiconv)
> +       ("libxrender" ,libxrender)
> +       ("mesa" ,mesa)
> +       ("pkg-config" ,pkg-config)
> +       ("pulseaudio" ,pulseaudio)))

Only ‘pkg-config’ needs to be native input, and libiconv can be omitted.

> +    (synopsis "Implementation of the Smalltalk programming language
> +and environment")

Removed “Implementation of the”.

I added a phase to remove PATH=/usr/bin in bin/squeak{,.sh}.

I also added a copyright line for you.

The next commit makes builds reproducible by removing timestamps from
the binaries.

Please let me know if anything is amiss!

Thanks,
Ludo’.