From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Use a directory owned by ntpd user for drift file.
Date: Fri, 09 Sep 2016 11:30:41 +0200
Message-ID: <87lgz18loe.fsf@gnu.org>
References: <1473277956-22799-1-git-send-email-jmd@gnu.org>
	<CAEwRq=rnxe7j+MjO-FscNHh4nWHKiAeXtjCjSp2CX_B3nNoRyw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39584)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1biI94-0000ZV-Rs
	for guix-devel@gnu.org; Fri, 09 Sep 2016 05:30:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1biI8z-0004zh-TO
	for guix-devel@gnu.org; Fri, 09 Sep 2016 05:30:49 -0400
In-Reply-To: <CAEwRq=rnxe7j+MjO-FscNHh4nWHKiAeXtjCjSp2CX_B3nNoRyw@mail.gmail.com>
	(Vincent Legoll's message of "Thu, 8 Sep 2016 08:57:57 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>, John Darrington <jmd@gnu.org>

Hi,

Vincent Legoll <vincent.legoll@gmail.com> skribis:

>> +(define (ntp-service-activation config)
>> +  "Return the activation gexp for config"
>> +  #~(begin
>> +      (use-modules (guix build utils))
>> +
>> +      (define %user
>> +        (getpw "ntpd"))
>> +
>> +      (let ((directory "/var/run/ntpd"))
>> +          (mkdir-p directory)
>> +          (chown directory (passwd:uid %user) (passwd:gid %user)))))
>> +
>
> Excuse my scheme-newbie questions, but
>
> - why did you use %user (I thought %s were for kind of global vars) ?

In the context of this gexp it=E2=80=99s a global variable.

> - why did you use define and not put it in the let just below ? Idon't see
> it being used elsewhere...

Both styles are OK, though putting it in the =E2=80=98let=E2=80=99 would ha=
ve made it
more concise, indeed.  :-)

Ludo=E2=80=99.