Re: [PATCH 1/2] gnu: Add femtolisp.

[ng0 <ng0@we.make.ritual.n0.is>]

ng0 <ng0@we.make.ritual.n0.is> writes:

> [ Unknown signature status ]
> From 4061b7fb71a40591dd8e34ee147153aa0d1d9fdc Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Tue, 13 Sep 2016 20:19:57 +0000
> Subject: [PATCH] gnu: femtolisp: Remove custom "patch-makefile" phase.
>
> * gnu/packages/lisp.scm (femtolisp)[arguments]: Remove
> "patch-makefile" phase; specify test target; build "release"
> target instead of "default".
> ---
>  gnu/packages/lisp.scm | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index 3461de4..c7b8f35 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -503,19 +503,11 @@ the InterLisp Standard.")
>                    "04rnwllxnl86zw8c6pwxznn49bvkvh0f1lfliy085vjzvlq3rgja"))))
>        (build-system gnu-build-system)
>        (arguments
> -       `(#:make-flags '("CC=gcc")
> -         #:tests? #f ; No make check
> +       `(#:make-flags '("CC=gcc" "release")
> +         #:test-target "test"
>           #:phases
>           (modify-phases %standard-phases
>             (delete 'configure) ; No configure script
> -           ;; We have to remove the 'test phase because it requires
> -           ;; the flisp binary to be present. Instead we run
> -           ;; bootstrap.sh after the 'install phase.
> -           (add-before 'build 'patch-makefile
> -             (lambda _
> -               (substitute* "Makefile"
> -                 (("default: release test") "default: release"))
> -               #t))
>             (replace 'install ; Makefile has no 'install phase
>              (lambda* (#:key outputs #:allow-other-keys)
>                (let* ((out (assoc-ref outputs "out"))
> @@ -533,7 +525,7 @@ the InterLisp Standard.")
>                   (install-file "flisp.boot" bin))))))))
>        (synopsis "Scheme-like lisp implementation")
>        (description
> -       "@code{femtolisp} is a scheme-like lisp implementation with a
> +       "@code{femtolisp} is a Scheme-like lisp implementation with a

I just noticed this.. I need to send the patch again. Anyone up to
reviewing and applying it today so I can mark these threads as done?

>  simple, elegant Scheme dialect.  It is a lisp-1 with lexical scope.
>  The core is 12 builtin special forms and 33 builtin functions.")
>        (home-page "https://github.com/JeffBezanson/femtolisp")
> -- 
> 2.10.0
>
>

Andreas: I reported the failing builds upstream to get
conformation. https://github.com/JeffBezanson/femtolisp/issues/25


-- 
              ng0