From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] add fbida Date: Sun, 16 Oct 2016 14:05:05 -0400 Message-ID: <87lgxob25q.fsf@openmailbox.org> References: <20161015145914.020916c3@polymos.lepiller.eu> <8760otcp57.fsf@openmailbox.org> <20161016101638.6cc78407@polymos.lepiller.eu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvpoH-0007Zy-Lv for guix-devel@gnu.org; Sun, 16 Oct 2016 14:05:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvpoD-0000pc-32 for guix-devel@gnu.org; Sun, 16 Oct 2016 14:05:21 -0400 Received: from smtp7.openmailbox.org ([62.4.1.41]:51660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvpoC-0000ow-RC for guix-devel@gnu.org; Sun, 16 Oct 2016 14:05:17 -0400 In-Reply-To: <20161016101638.6cc78407@polymos.lepiller.eu> (Julien Lepiller's message of "Sun, 16 Oct 2016 10:16:38 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Julien Lepiller writes: > On Sat, 15 Oct 2016 16:51:00 -0400 > Kei Kebreau wrote: > >> Julien Lepiller writes: >>=20 >> > Hi, >> > >> > I attached a patch to add fbida, a frame-buffer based image and pdf >> > viewer. I created a new file, since I didn't find an existing one >> > where it could go. Let me know if you prefer it in an existing >> > file.=20=20 >>=20 >> Hi Julien! Your patch looks fine as far as linting and reproducibility >> goes. Some pointers for your patch: >>=20 >> In my opinion, this can go in pdf.scm, as the mupdf package is there >> and it has similar functions to fbida. Also, when you add fbida to >> pdf.scm, don't forget to add a copyright notice for yourself! > > I attached an updated patch. Thanks! This works just as well for me. Pushed as f3e222165e7c2393441346d4efd82d03a84a1fac. For future reference, when adding a package you only need gnu: Add [package]. * gnu/packages/[file].scm ([package]): New variable. as far as commit syntax goes. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYA8FRAAoJEOal7jwZRnoNt6MP/RU4oQK3VH7o4i7SLpt9t2DZ cJZXNHjLygPVBmVd1C6TLSWeh8ataQmBHjpUOIzOQeHHVmSWbnUu7g0OjV/QwsBn voYcZ48w4hp/kwf8OoxVMoIktrK4UYk+X7B7bkq4KdbFLC9NgHj5f/QtAF9i1dj+ FgMIF06RM3CjQnaMAZNGkLSL4ihd9QMoUuXyN4RqnqezWcsvpcF5XSCFcm3wg+2L DMRAkMIsuEvt222GQs6cZ4F2J4w3pM7Wb+VLVmkmdkZxEbX2vhD2bpkZM/S710uK AhyuZX+eRQYajU1K4wtC+R7w79Fz+zIZyFjqNEzFktHgaZjoQ+i/RFMOlaZB/L5c TBLxwsxIZXrVeiDgIOP7NlbtxWM7hXUZDYiYayIotqHPMx2I9xE/gt8nLyOKXCTy oW/DExS3uO1jMBm/t0TBgWD8fZOW6dYhkQrlVbt64A+UmqgyzYJetyw3avvEQkAy F11/WZ2jX8neATGMH4Dp/RuLOL0ypn7/liuWU6WgsZpBkTxZlEx4wNPNaOWlx9zu YhyjkghWbg0X9NqCPPO5nzeHjh7k8i45F1v2QEsqqUah9IzGg2M21xlPu3GvM4q5 +/HIAmPETTae4Ggozmo4jnnkTmytaXi9H4hiomtcEMD83ktXXXatbD8+UhvacGMx F3SDiwpPftOu12Ahfw51 =lQ91 -----END PGP SIGNATURE----- --=-=-=--