all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org, Federico Beffa <beffa@fbengineering.ch>
Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello.
Date: Fri, 28 Oct 2016 12:30:13 +0300	[thread overview]
Message-ID: <87lgx8ddne.fsf@gmail.com> (raw)
In-Reply-To: <87mvhpfx22.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 27 Oct 2016 20:48:05 +0200")

Ricardo Wurmus (2016-10-27 20:48 +0200) wrote:

> Alex Kost <alezost@gmail.com> writes:
>
>>> @Alex: could you please confirm this?  Should these inputs be mentioned
>>> at all?  If so, is it sufficient to add them to native-inputs?
>>
>> As for me, I don't see a reason to add these additional inputs,
>> emacs-build-system will not run tests anyway.
>
> Thank you for clarifying.
>
> Is there a reason why we don’t run the tests?  We do this by default for
> all other packages.

How can it be done?  There is no common way for emacs packages to
perform tests: only some packages have Makefile (with "check" phase),
and it would be a really good luck if "make check" as is succeeded for
them.  Usually such projects use Cask to run tests or even some custom
scripts.  They may use just "ert" or "ert-running" package (or maybe
something else).

After all, I think that adding a 'check' phase to emacs-build-system is
not worth an effort: there would be too much manual interventions in
package recipes to make tests work for different emacs packages.

But I better let Federico speak about «why we don’t run the tests» as he
wrote emacs-build-system :-)

-- 
Alex

  reply	other threads:[~2016-10-28  9:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 21:09 [PATCH 2/2] gnu: Add emacs-org-trello Roel Janssen
2016-10-25 21:26 ` Ricardo Wurmus
2016-10-27  8:31   ` Roel Janssen
2016-10-27 14:09     ` Ricardo Wurmus
2016-10-27 18:22       ` Alex Kost
2016-10-27 18:48         ` Ricardo Wurmus
2016-10-28  9:30           ` Alex Kost [this message]
2016-10-28 13:03             ` Roel Janssen
2016-10-28 16:35               ` Ricardo Wurmus
2016-10-28 17:52                 ` Roel Janssen
2016-10-28 16:21             ` Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgx8ddne.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=beffa@fbengineering.ch \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.