From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 3/4] gnu: Add psyclpc. Date: Sun, 30 Oct 2016 12:46:55 +0000 Message-ID: <87lgx657i8.fsf@we.make.ritual.n0.is> References: <20160929103810.10273-1-ngillmann@runbox.com> <20160929103810.10273-3-ngillmann@runbox.com> <87d1ii9xvf.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0pW1-0003sa-Qr for guix-devel@gnu.org; Sun, 30 Oct 2016 08:47:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0pVy-0005JJ-Nh for guix-devel@gnu.org; Sun, 30 Oct 2016 08:47:09 -0400 Received: from aibo.runbox.com ([91.220.196.211]:59794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0pVy-0005IP-E8 for guix-devel@gnu.org; Sun, 30 Oct 2016 08:47:06 -0400 In-Reply-To: <87d1ii9xvf.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Sun, 30 Oct 2016 07:03:48 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: > ng0 writes: > >> * gnu/packages/psyc.scm (psyclpc): New variable. >> --- >> gnu/packages/psyc.scm | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 79 insertions(+) >> >> diff --git a/gnu/packages/psyc.scm b/gnu/packages/psyc.scm > > As before, please add this to “messaging”. Okay. I will move the already added module psyc.scm in master to messaging then. It's not exclusive messaging, but I don't really care where it ends up. psyc.scm was just a suggestion I made (which can be read in the very first message for this patch set). >> + >> +;; This commit removes the historic bundled pcre, not released as a tarball so far. >> +(define-public psyclpc >> + (let* ((commit "8bd51f2a4847860ba8b82dc79348ab37d516011e") >> + (revision "1")) > > Okay. > >> + (package >> + (name "psyclpc") >> + (version (string-append "20160821-" revision "." (string-take commit 7))) >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "git://git.psyced.org/git/psyclpc") >> + (commit commit))) >> + (sha256 >> + (base32 >> + "10w4kx9ygcv1lcmd7j4knvjiy8dac1y3hjfv3lhp67jpv6w3iagz")))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:tests? #f ; There are no tests/checks. >> + #:configure-flags >> + ;; If you have questions about this part, look at >> + ;; "src/settings/psyced" and the ebuild. > > Please don’t do this. Guix is not a derivative of Gentoo. This should > be explained right here. > >> + (list >> + "--enable-use-tls=yes" >> + "--enable-use-mccp" ; Mud Client Compression Protocol, leave this enabled. >> + (string-append "--prefix=" >> + (assoc-ref %outputs "out")) >> + ;; src/Makefile: Set MUD_LIB to the directory which contains >> + ;; the mud data. defaults to MUD_LIB = @libdir@ >> + (string-append "--libdir=" >> + (assoc-ref %outputs "out") >> + "/opt/psyced/world") >> + (string-append "--bindir=" >> + (assoc-ref %outputs "out") >> + "/opt/psyced/bin") >> + ;; src/Makefile: Set ERQ_DIR to directory which contains the >> + ;; stuff which ERQ can execute (hopefully) savely. Was formerly >> + ;; defined in config.h. defaults to ERQ_DIR= @libexecdir@ >> + (string-append "--libexecdir=" >> + (assoc-ref %outputs "out") >> + "/opt/psyced/run")) > > I don’t think it’s wise to override the target directories to have a > prefix of “/opt/psyced”. We already have a prefix: > “/gnu/store/--/”. If this is needed at runtime for > some reason it should be done by a service. > >> + #:phases >> + (modify-phases %standard-phases >> + (add-before 'configure 'chdir-to-src >> + ;; We need to pass this as env variables >> + ;; and manually change the directory. > > What is “this”? > >> + (lambda _ >> + (chdir "src") >> + (setenv "CONFIG_SHELL" (which "sh")) >> + (setenv "SHELL" (which "sh"))))) > > CONFIG_SHELL and SHELL are usually set for autoconf. Why does this not > work in this case? > > Please end the phase with #t. > >> + #:make-flags (list "install-all"))) >> + (inputs >> + `(("zlib" ,zlib) >> + ("openssl" ,openssl) >> + ("pcre" ,pcre))) >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("bison" ,bison) >> + ("gnu-gettext" ,gnu-gettext) >> + ("help2man" ,help2man) >> + ("autoconf" ,autoconf) >> + ("automake" ,automake))) >> + (home-page "http://lpc.psyc.eu/") >> + (synopsis "psycLPC is a multi-user network server programming >> language") > > s/psycLPC is a// > >> + (description >> + "LPC is a bytecode language, invented to specifically implement >> +multi user virtual environments on the internet. This technology is used for >> +MUDs and also the psyced implementation of the Protocol for SYnchronous Conferencing (PSYC). psycLPC is a fork of LDMud with some new features and >> +many bug fixes.") > > Please fix the line lengths. As far as I know you picked an old thread and I fixed this in a newer one. If I'm wrong about this, there'll be a new thread soon enough. >> + (license license:gpl2)))) > > GPLv2 only? Yes, but since 2010 there's also a different license, as this was originally up to someone else to review, I'll add again: I have to send in a new patch revisision. psyclpc also needs a fix for reproducibility which I will pass on directly to one of us with push access. After psyclpc is fixed at our end, I will send new versions to guix. > > ~~ Ricardo > Thanks for review