From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: fftw: Build threads library.
Date: Tue, 15 Nov 2016 11:13:27 +0100
Message-ID: <87lgwlf3ug.fsf@gnu.org>
References: <20161114224342.11644-1-rekado@elephly.net>
	<20161114224342.11644-2-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c6akD-00055e-78
	for guix-devel@gnu.org; Tue, 15 Nov 2016 05:13:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c6akA-0004PZ-2G
	for guix-devel@gnu.org; Tue, 15 Nov 2016 05:13:37 -0500
In-Reply-To: <20161114224342.11644-2-rekado@elephly.net> (Ricardo Wurmus's
	message of "Mon, 14 Nov 2016 23:43:42 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
> configure flags.
> ---
>  gnu/packages/algebra.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
> index 8e9695d..e212775 100644
> --- a/gnu/packages/algebra.scm
> +++ b/gnu/packages/algebra.scm
> @@ -544,7 +544,8 @@ a C program.")
>                 "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:configure-flags '("--enable-shared" "--enable-openmp")
> +     '(#:configure-flags
> +       '("--enable-shared" "--enable-openmp" "--enable-threads")
>         #:phases (alist-cons-before
>                   'build 'no-native
>                   (lambda _

LGTM!

Per
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
this is a perfect candidate for =E2=80=98staging=E2=80=99.

(In the meantime, if that helps, you could additionally create an FFTW
variant for use by Ardour, in master.)

Ludo=E2=80=99.