Re: [PATCH] gnu: mupdf: Fix some security problems in bundled mujs.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Jan 12, 2017 at 07:59:40PM -0500, Mark H Weaver wrote:
>> Here's what we can do: in addition to mupdf itself, we can also add a
>> graft for cups-filters (our only package that includes mupdf as an
>> input).  The replacement for cups-filters would change its mupdf input
>> to refer directly to the fixed version of mupdf.
>> 
>> What do you think?
>
> I've attached two patches that should do this.

Thanks for doing this!
  
> +(define cups-filters/fixed
> +  (package
> +    (inherit cups-filters)
> +    (inputs
> +     `(("avahi"        ,avahi)
> +       ("fontconfig"   ,fontconfig)
> +       ("freetype"     ,freetype)
> +       ("font-dejavu"  ,font-dejavu) ; also needed by test suite
> +       ("ghostscript"  ,(force ghostscript/cups))
> +       ("ijs"          ,ijs)
> +       ("dbus"         ,dbus)
> +       ("lcms"         ,lcms)
> +       ("libjpeg"      ,libjpeg)
> +       ("libpng"       ,libpng)
> +       ("libtiff"      ,libtiff)
> +       ("mupdf"        ,(@@ (gnu packages pdf) mupdf/fixed))
> +       ("glib"         ,glib)
> +       ("qpdf"         ,qpdf)
> +       ("poppler"      ,poppler)
> +       ("cups-minimal" ,cups-minimal)))))

Is it possible to use the 'package-input-rewriting' procedure here? See
example at the end of section 5.1.0:

https://www.gnu.org/software/guix/manual/guix.html#Defining-Packages

Otherwise this LGTM, thanks a lot!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]