From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH core-updates 6/6] utils: Add helper method to make files
	writable.
Date: Thu, 26 Jan 2017 10:50:50 +0100
Message-ID: <87lgty5ev9.fsf@gnu.org>
References: <20170125171938.27271-1-mbakke@fastmail.com>
	<20170125171938.27271-7-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cWghn-0007hU-Ok
	for guix-devel@gnu.org; Thu, 26 Jan 2017 04:51:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cWghh-0002a2-VK
	for guix-devel@gnu.org; Thu, 26 Jan 2017 04:50:59 -0500
In-Reply-To: <20170125171938.27271-7-mbakke@fastmail.com> (Marius Bakke's
	message of "Wed, 25 Jan 2017 18:19:38 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/build/activation.scm (make-file-writable): Move this to ...
> * guix/build/utils.scm (make-file-writable): ... here. Export it.
> * guix/build/gnu-build-system.scm (strip): Use it.

[...]

> --- a/guix/build/gnu-build-system.scm
> +++ b/guix/build/gnu-build-system.scm
> @@ -393,8 +393,10 @@ makefiles."
>                       (or (elf-file? file) (ar-file? file))
>                       (or (not debug-output)
>                           (make-debug-file file))
> -                     ;; Ensure libraries are writable.
> -                     (chmod file #o755)
> +
> +                     ;; Ensure the file is writable.
> +                     (make-file-writable file)

The return value of =E2=80=98chmod=E2=80=99 and =E2=80=98make-file-writable=
=E2=80=99 is unspecified, so
you need to write:

  (begin (make-file-writable file) #t)

> +(define (make-file-writable file)
> +  "Make FILE writable for its owner.."
                                      ^
Take it as an opportunity to remove this extra period.  :-)

Otherwise LGTM.

Ludo=E2=80=99.