From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 00/10] ocaml patches
Date: Wed, 08 Feb 2017 12:21:20 +0100
Message-ID: <87lgthq66n.fsf@gnu.org>
References: <20170131205815.14576-1-julien@lepiller.eu>
	<20170207211618.2a600ca0@lepiller.eu>
	<5664b4e3-b02d-b2be-96fc-3e9cd031460b@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cbQJS-0001lZ-K7
	for guix-devel@gnu.org; Wed, 08 Feb 2017 06:21:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cbQJP-0002L9-E7
	for guix-devel@gnu.org; Wed, 08 Feb 2017 06:21:26 -0500
In-Reply-To: <5664b4e3-b02d-b2be-96fc-3e9cd031460b@uq.edu.au> (Ben Woodcroft's
	message of "Wed, 8 Feb 2017 08:24:07 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: guix-devel@gnu.org

Hi,

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 08/02/17 06:16, Julien Lepiller wrote:
>> On Tue, 31 Jan 2017 21:58:05 +0100
>> Julien Lepiller <julien@lepiller.eu> wrote:
>>
>>> Here is the next series of patches. I think I took into account all
>>> of your previous remarks, so it should be faster.
>>>
>>> Julien Lepiller (10):
>>>    gnu: Add ocaml-fieldslib.
>>>    gnu: Add ocaml-ppx-core.
>>>    gnu: Add ocaml-ppx-optcomp.
>>>    gnu: Add ocaml-ppx-driver.
>>>    gnu: Add ocaml-cppo.
>>>    gnu: Add ocaml-ppx-deriving.
>>>    gnu: Add ocaml-ppx-type-conv.
>>>    gnu: Add ocaml-ppx-inline-test.
>>>    gnu: Add ocaml-ppx-bench.
>>>    gnu: Add ocaml-ppx-compare.
>>>
>>>   gnu/packages/ocaml.scm | 255
>>> +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 255
>>> insertions(+)
>>>
>> Up?
>>
>> Can I push them?
> I've been meaning to review these patches but haven't found the time..
>
> If they pass 'guix lint' then I would think it is OK to push
> them. Thanks for your efforts on the OCaml front.

I concur, sorry for the delay Julien!

That=E2=80=99s really a minor issue but in the future, please make sure
descriptions contain full sentences and use @code and similar where it
makes sense.

Also, feel free to push simple packages if they pass =E2=80=98guix lint=E2=
=80=99 and you
don=E2=80=99t get feedback within a few days (see =E2=80=98HACKING=E2=80=99=
).

Thanks for working the OCaml front!  :-)

Ludo=E2=80=99.