all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kei@openmailbox.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: ntfs-3g: Does it build?
Date: Sat, 18 Feb 2017 18:11:34 -0500	[thread overview]
Message-ID: <87lgt314d5.fsf@openmailbox.org> (raw)
In-Reply-To: <20170218231340.7c8127da@scratchpost.org> (Danny Milosavljevic's message of "Sat, 18 Feb 2017 23:13:40 +0100")

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi Kei,
>
> I think the empty line except for the whitespace is the only important line - see below. The number of spaces is different.
>
> diff --git a/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch b/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch
> index 6edd676e3..dfaeca080 100644
> --- a/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch
> +++ b/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch
> @@ -12,7 +12,7 @@ diff -ur ntfs-3g.old/src/lowntfs-3g.c ntfs-3g/src/lowntfs-3g.c
>  +      char *env = (char*)NULL;
>         struct timespec req = { 0, 100000000 };   /* 100 msec */
>         fuse_fstype fstype;
> -        
> +         
>         if (!stat(cmd, &st) && !geteuid()) {
>                 pid = fork();
>                 if (!pid) {

Indeed. It looks like diff adds an extra space at the beginning of code
lines to leave space for the + and - signs. Applying the patch let
ntfs-3g build again on my side. Was there any change for you using the
patch I just sent?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-02-18 23:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 17:32 ntfs-3g: Does it build? Danny Milosavljevic
2017-02-18 19:51 ` Kei Kebreau
2017-02-18 22:13   ` Danny Milosavljevic
2017-02-18 23:11     ` Kei Kebreau [this message]
2017-02-18 23:27       ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgt314d5.fsf@openmailbox.org \
    --to=kei@openmailbox.org \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.