From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv1IC-0006la-6I for guix-patches@gnu.org; Mon, 03 Apr 2017 08:41:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv1I7-0006JJ-AM for guix-patches@gnu.org; Mon, 03 Apr 2017 08:41:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cv1I6-0006JB-Mj for guix-patches@gnu.org; Mon, 03 Apr 2017 08:41:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cv1I6-0006th-AG for guix-patches@gnu.org; Mon, 03 Apr 2017 08:41:02 -0400 Subject: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87pogu45y3.fsf@openmailbox.org> References: <20170402155211.23494-1-kei@openmailbox.org> <87y3viv55d.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87pogu45y3.fsf@openmailbox.org> Date: Mon, 03 Apr 2017 14:40:10 +0200 Message-ID: <87lgrhbr6d.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: 26343@debbugs.gnu.org --=-=-= Content-Type: text/plain Kei Kebreau writes: > Marius Bakke writes: > >>> (build-system gnu-build-system) >>> (inputs >>> ;; TODO: Add portSMF and libwidgetextra once they're packaged. In-tree >>> @@ -73,7 +79,10 @@ >>> ("lilv" ,lilv) >>> ("portaudio" ,portaudio))) >>> (native-inputs >>> - `(("gettext" ,gettext-minimal) ;for msgfmt >>> + `(("autoconf" ,autoconf) >>> + ("automake" ,automake) >>> + ("gettext" ,gettext-minimal) ;for msgfmt >>> + ("libtool" ,libtool) >>> ("pkg-config" ,pkg-config) >>> ("python" ,python-2) >>> ("which" ,which))) >>> @@ -90,6 +99,12 @@ >>> (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz") >>> (string-append "LIBMAD_CFLAGS=-I" libmad "/include") >>> (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad"))) >>> + #:phases >>> + (modify-phases %standard-phases >>> + ;; Ensure the usage of system libraries. >>> + (add-before 'configure 'autoreconf >>> + (lambda _ >>> + (zero? (system* "autoreconf" "-vfi"))))) >> >> Can you clarify how autoreconf ensures usage of system libraries? >> Usually it just re-generates configure scripts and Makefiles from >> templates, but should not make any functional difference. > > FFmpeg is not detected if autoreconf doesn't run for some reason. With > this phase, everything is detected like normal. Oh. Please mention that in the comment then. Thank you! :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljiQqoACgkQoqBt8qM6 VPrn/wf/UgDYBmx3M0XCGNX9tEhmUe1GUTefhps5vnXCE0BT3Ek+Yb4PIQjTlZzV ySf73AY80iTLX9VBy3JCCjp5b+dkxmQxbhMcm9BfdLtptHaJARRLbvaydn13DXpk gjL3GGlvHeFCn8qkpbHredvXb3kL1Plw/L+12uySfVeG1c9QMu+vKc9jhdJRx9DC OYZQiFRBETPCAy3QPcFfMr4xy+gp997bR/te8FyxAYHWkVGRnyBK5jmoBdiHUEwS 2TBfXK2eMkZY6KrZpPfp5WAwaN1lUBMC8bdm5uWrw6Kac2AFI7QiCJPyX0EaD4rb +8VZOrCgZVMo8iZptCBm3IqgMM6tgQ== =kvrD -----END PGP SIGNATURE----- --=-=-=--