From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d08I4-0001P4-Tl for guix-patches@gnu.org; Mon, 17 Apr 2017 11:10:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d08Hz-0007LZ-3d for guix-patches@gnu.org; Mon, 17 Apr 2017 11:10:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d08Hy-0007LP-L1 for guix-patches@gnu.org; Mon, 17 Apr 2017 11:10:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d08Hy-0007Z7-FW for guix-patches@gnu.org; Mon, 17 Apr 2017 11:10:02 -0400 Subject: bug#26522: gnu: Add adb Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170417104022.3947db41@lepiller.eu> References: <20170415183146.45f95eda@lepiller.eu> <87a87hmtv7.fsf@fastmail.com> <20170416112200.51037253@lepiller.eu> <87pogckogo.fsf@fastmail.com> <20170417104022.3947db41@lepiller.eu> Date: Mon, 17 Apr 2017 17:09:04 +0200 Message-ID: <87lgqzkr5b.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller , 26522@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Lepiller writes: > Le Sun, 16 Apr 2017 23:54:47 +0200, > Marius Bakke a =C3=A9crit : > >> Julien Lepiller writes: >>=20 >> > Hi Marius, >> > >> > thanks for the quick review. This should fix your comments. >>=20 >> Great! One thing I overlooked last time was the patches. It would be >> good to include the origin in URL form, so we can dig them out later. >>=20 >> The arch patch shouldn't be too hard to find (but URL would be >> convenient!), I'm curious where the other patch comes from. >>=20 >> Patches tend to evolve over time, so checking what happened "upstream" >> can be handy when you're stumped. See e.g. any CVE patch for >> examples :) >>=20 >> Other than that looks good! > > Here is an updated patch with a link to archlinux' patch. You were the > one to add the other patch, and I can't find it. I'm also curious where > it comes from :p Hehe...I deliberately did not add a reference just to prove this point! ...but I remember now, it is this commit, which I don't think will hit a release until Android 8 if I've understood their branching correctly: https://android.googlesource.com/platform/system/core/+/e5dd71a290f664d3f3b= f0dd8a4bad411dc7ad416 Please add it and push! :D --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlj02pEACgkQoqBt8qM6 VPrs4QgAjh4t0y+WM5pweKjDRxrPD4aQCE3j+MFpzwevYsYub8NCC4/lgR+IzoDu AGftCAh5mTPnoR2XQ+9f73NQwcCpo3LY8QhlC6cCrwpjSoQlJszO3N80jV6PiBhz P6apgAccXB6CZWA3RHnq6faJAhQuKDzGwjjuT6jDOMwciK0Ts8s8iXO+iE6T0gSk ox0QeQrK8v6AgcbOGbFisYWYnT/03z7FiV6z041bqx6zwcZ6fypCbVkRoTgFBRMV INnzF+HLX3pw+H5+9GX+shKs9rvAjUROuj5SH8URR5Kx8CWQRg+51QzgP6qiEpHK +0hjceyqnM12N4pDJmg+xGO87XKyXA== =KWb0 -----END PGP SIGNATURE----- --=-=-=--