From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1URA-00076W-Jv
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:01:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1UR4-0003m3-Or
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:01:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33306)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d1UR4-0003lt-Lk
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1UR4-0002HD-Di
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:01:02 -0400
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Resent-Message-ID: <handler.26500.B26500.14927652417581@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <db842df1-7c87-58a0-2eab-b91e3a36851b@cock.li>
	<633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com>
	<7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li>
	<3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com>
Date: Fri, 21 Apr 2017 11:00:27 +0200
In-Reply-To: <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com>
	(Arun Isaac's message of "Wed, 19 Apr 2017 21:23:49 +0530")
Message-ID: <87lgqu3zkk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>, nee <nee@cock.li>
Cc: 26500@debbugs.gnu.org

Hello!

Arun Isaac <arunisaac@systemreboot.net> skribis:

> nee writes:

[...]

>> @@ -28,6 +29,7 @@
>>    #:use-module (guix packages)
>>    #:use-module (guix build-system gnu)
>>    #:use-module (guix build-system cmake)
>> +  #:use-module (guix build-system python)
>>    #:use-module (gnu packages autotools)
>>    #:use-module (gnu packages algebra)
>>    #:use-module (gnu packages base)
>> @@ -46,6 +48,7 @@
>>    #:use-module (gnu packages pkg-config)
>>    #:use-module (gnu packages qt)
>>    #:use-module (gnu packages xorg)
>> +  #:use-module (gnu packages python)
>>    #:use-module (gnu packages))
>
> Since these modules are already in alphabetical order, it would be good
> to keep them that way. Insert (gnu packages python) at an appropriate
> position.
>
>> +    (inputs `(("python2-pillow" ,python2-pillow)
>> +              ("python2-pygtk" ,python2-pygtk)
>> +              ("p7zip" ,p7zip)))
>
> Please put these in alphabetical order too. That means p7zip will go on
> the top.
>
>> +    (description "MComix is a customizable image viewer that specialize=
s as
>> +a comic and manga reader.  It supports a variety of container formats
>> +including CBZ, CB7, CBT, LHA.
>> +CBR and rar are currently unsupported, due to unfree dependencies.
>> +For optional pdf support, you can install the mupdf package.")
>
> Can we move the information about RAR and PDF support to a comment above
> the package definition, as done for the octave package?

I agree with the comments, though I also think this shouldn=E2=80=99t block=
 the
patch or drive nee away.  :-)

Ludo=E2=80=99.