From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUx7v-0000fJ-ED for guix-patches@gnu.org; Tue, 11 Jul 2017 11:31:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUx7u-0004nO-Dm for guix-patches@gnu.org; Tue, 11 Jul 2017 11:31:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUx7u-0004nF-AX for guix-patches@gnu.org; Tue, 11 Jul 2017 11:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUx7u-00045Y-21 for guix-patches@gnu.org; Tue, 11 Jul 2017 11:31:02 -0400 Subject: [bug#27520] [PATCH v2] build, vm: Use "GuixSD" or "GUIXSD" as volume label. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170702120557.07355db9@scratchpost.org> <20170710030440.4282-1-dannym@scratchpost.org> <87a84c60os.fsf@gnu.org> <20170710153750.1706413c@scratchpost.org> Date: Tue, 11 Jul 2017 17:30:44 +0200 In-Reply-To: <20170710153750.1706413c@scratchpost.org> (Danny Milosavljevic's message of "Mon, 10 Jul 2017 15:37:50 +0200") Message-ID: <87lgnvvvmj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 27520-done@debbugs.gnu.org Hi Danny, Danny Milosavljevic skribis: > On Mon, 10 Jul 2017 12:33:39 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> > +++ b/gnu/build/vm.scm >> > @@ -431,7 +431,7 @@ passing it a directory name where it is mounted." >> > (lambda (port) >> > (format port >> > "insmod part_msdos~@ >> > - search --set=3Droot --label gnu-disk-image~@ >> > + search --set=3Droot --label GuixSD~@ >> > configfile /boot/grub/grub.cfg~%")))=20=20 >>=20 >> This won=E2=80=99t cause problems with ISO images, right? > > Good question. > > I successfully tested it in qemu (both iso9660 and normal disk-image). > > I also ran the system checks. Some work, some don't work. The bootup pa= rt does generally work. > > But I'm not that knowledgeable with UEFI, so no idea whether ISO9660 boot= up would even use this UEFI wrapper thing. > > Anyway, it doesn't worsen anything so I pushed it to master, commit 651de= 2bdb5fd451c50933dcf8d647d470d826261. Cool! > P.S. Some system tests look not-so-good either with or without the patch = applied: [...] > TOTAL: 19 > PASS: /gnu/store/jsmkjv57sdycy89whbpj8w0ggzladmy1-basic > PASS: /gnu/store/i3rpc4na0s8n3ys37qlrzbmsd63g0x4n-mcron > PASS: /gnu/store/dx2ibskh8a6qirk20n19d5xam2wk3yzy-opensmtpd-test > PASS: /gnu/store/xgmmghm577xp41w6j1xlzr912x7c1l72-prosody > PASS: /gnu/store/dl4bjcwwgrrp84mmfm4gcxrp9mfvcwqs-inetd-test > PASS: /gnu/store/9hg2bp1yk5mdl3wqgfkzvdxm1qmkk6pz-nfs > PASS: /gnu/store/658s8abgckc4anzlqh9sn17vjhngnyy1-openssh > PASS: /gnu/store/p6visdc6p4najg7dy4rfpy201136ysn5-dropbear > PASS: /gnu/store/kynb05cj7kd5kfh9690xwm0i8gvc536z-nginx-test > FAIL: /gnu/store/90484bwhiizialy1qfvm3gk2fn9r499n-nss-mdns This one is =E2=80=9Cknown to fail=E2=80=9D. > FAIL: /gnu/store/csxh0dnpbjqc8q1qkb9j5gbjrlhbpy7v-dicod > FAIL: /gnu/store/6vp4xg0zzrcz5ksdykd9zr5ydwpvjgvk-btrfs-root-os > FAIL: /gnu/store/5lw5gfvljp3kkf32k71g2vik258g9jpj-raid-root-os > FAIL: /gnu/store/n5dq0nx8vgw6ci6wpl7r78bchfs29lfc-installed-os > FAIL: /gnu/store/bm6n23mp1x74jj57kvy2hlfhi2iyxjhs-encrypted-root-os > FAIL: /gnu/store/3sjjq1xavrvhkbj7hqbjgvmcmpagmcpz-installed-extlinux-os > FAIL: /gnu/store/0mj78x3awxwrrjp9s53xgcaa1y5aps8k-separate-store-os > FAIL: /gnu/store/64wmjlfidh0mzl700zfqmrxmc475vhbk-separate-home-os > FAIL: /gnu/store/xrbg9b6xc1q26byw0pxi0lk7q58p3z52-exim-test =E2=80=A6 but those are alarming. =E2=80=9Cmake check-system TESTS=3D"dicod exim"=E2=80=9D works for me on cu= rrent master; I haven=E2=80=99t checked the other ones. Could you see what=E2=80=99s wrong? Thanks, Ludo=E2=80=99.