From: Roel Janssen <roel@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 29880@debbugs.gnu.org
Subject: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Date: Mon, 08 Jan 2018 17:28:53 +0100 [thread overview]
Message-ID: <87lgh8iabe.fsf@gnu.org> (raw)
In-Reply-To: <87mv1ok9ab.fsf@gnu.org>
Ludovic Courtès writes:
> Hi Oleg,
>
> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> This patch allows to grep with perl regular expression.
>>
>> From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Thu, 28 Dec 2017 22:12:13 +0300
>> Subject: [PATCH] gnu: grep: Add PCRE support.
>>
>> * gnu/packages/base.scm (grep)[inputs]: New field.
>
> This would be for the next ‘core-updates’. Did you try a full rebuild?
>
> I’m mildly wary of this change because PCRE is a non-trivial piece of
> software that increases the attack surface, and we’d end up grafting
> things potentially often. For instance, right now I get:
>
> $ guix lint pcre
> gnu/packages/pcre.scm:77:2: pcre@8.41: probably vulnerable to CVE-2017-11164
>
> Would it make sense to instead have a separate “grep-pcre”?
>
> What do people think?
I have been maintaining a separate package for grep with PCRE support
for the users on our cluster. What I would like to add is that at least
Debian and RedHat enable PCRE in their grep versions. So using Guix's
grep broke some scripts.
If compatibility with other GNU/Linux distributions counts for anything,
I'd say we should enable it. I am in favor of enabling PCRE.
We could provide a separate version of grep without PCRE as a
grep-minimal.
Thanks for your time!
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2018-01-08 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 19:18 [bug#29880] [PATCH] gnu: grep: Add PCRE support Oleg Pykhalov
2018-01-08 9:08 ` Ludovic Courtès
2018-01-08 16:28 ` Roel Janssen [this message]
2018-01-09 8:54 ` Ludovic Courtès
2018-01-09 11:23 ` Roel Janssen
2018-01-11 21:50 ` bug#29880: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgh8iabe.fsf@gnu.org \
--to=roel@gnu.org \
--cc=29880@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.