From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euaeh-0005gS-FN
	for guix-patches@gnu.org; Sat, 10 Mar 2018 04:19:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euaec-0006GP-J6
	for guix-patches@gnu.org; Sat, 10 Mar 2018 04:19:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45181)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1euaec-0006C3-CI
	for guix-patches@gnu.org; Sat, 10 Mar 2018 04:19:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euaeb-0007Hm-Sj
	for guix-patches@gnu.org; Sat, 10 Mar 2018 04:19:01 -0500
Subject: [bug#30748] [PATCH] gnu: Add nsd.
Resent-Message-ID: <handler.30748.B30748.152067348627927@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20180308082050.9855-1-me@tobias.gr>
References: <20180308082050.9855-1-me@tobias.gr>
Date: Sat, 10 Mar 2018 10:18:00 +0100
Message-ID: <87lgf0jnlj.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>, 30748@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> * gnu/packages/dns.scm (nsd): New public variable.

[...]

> +         (add-before 'configure 'patch-installation-paths
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (doc (string-append out "/share/doc/" ,name "-" ,version)))
> +               (substitute* "Makefile.in"
> +                 (((string-append ".*\\$\\(DESTDIR\\)\\$\\("
> +                                  "(config|pid|xfr|db)dir"
> +                                  "\\).*"))
> +                  "")

Can you add a comment about what's going on here?  Would setting
DESTDIR=(assoc-ref %outputs "out") in #:make-flags suffice?

Apart from that LGTM.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqjoskACgkQoqBt8qM6
VPqykwf/WYU88TbtKW2/RNcI2/BzTsqOmbtc/k2IP7wEtYo4HURedVRPBKpchqtf
YbI1P9JPkqDdXrk9fU7Ab1Tw1eVNVrlQC1E01lxdA2aow4dR6dRDTem84X+DRlyR
5V5fWAc5Z4vOwmeD2V6kjqhlmxjA0RUxjzdTjSDORm02Sa5taXQEYRQ7y/V8HM00
udvojbAQQg2R/a/GvTDG2xYaUA2uElEcDHedG8TDsiLgs/EKtJL4Q131hgcA7eni
oUfLIIp9gwEX/aPdjlThz8pTrvTKHa2LKFNKcUybRXVTrlJ/+l2xGgF/AuOHmwdL
mh5SbW/vGOA9vCGe8UQEnfwaVxzFxA==
=wnV7
-----END PGP SIGNATURE-----
--=-=-=--