From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTToE-0007IZ-T9 for guix-patches@gnu.org; Thu, 14 Jun 2018 11:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTTo7-0003Dj-M2 for guix-patches@gnu.org; Thu, 14 Jun 2018 11:05:09 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTTo7-0003De-F3 for guix-patches@gnu.org; Thu, 14 Jun 2018 11:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTTo6-0003oN-Jl for guix-patches@gnu.org; Thu, 14 Jun 2018 11:05:02 -0400 Subject: [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5. Resent-Message-ID: From: Kei Kebreau References: <20180606094730.15892-1-ambrevar@gmail.com> <87o9gd2zcy.fsf@posteo.net> Date: Thu, 14 Jun 2018 11:04:30 -0400 In-Reply-To: <87o9gd2zcy.fsf@posteo.net> (Kei Kebreau's message of "Thu, 14 Jun 2018 10:53:49 -0400") Message-ID: <87lgbh2yv5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31733@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kei Kebreau writes: > Hi Pierre, > >> * gnu/packages/crypto.scm (encfs): Update to 1.9.5. > > Don't forget to mention the new 'make-unittests' phase! > >> --- >> gnu/packages/crypto.scm | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm >> index f96fe0490..4707355f3 100644 >> --- a/gnu/packages/crypto.scm >> +++ b/gnu/packages/crypto.scm >> @@ -216,7 +216,7 @@ communication.") >> (define-public encfs >> (package >> (name "encfs") >> - (version "1.9.1") >> + (version "1.9.5") >> (source >> (origin >> (method url-fetch) >> @@ -225,7 +225,7 @@ communication.") >> version "/encfs-" version ".tar.gz")) >> (sha256 >> (base32 >> - "1906254dg5hwljh0h4gyrw09ms3b57dlhjfzhfzffv50yzpkl837")) >> + "0qzxavvv20577bxvly8s7d3y7bqasqclc2mllp0ddfncjm9z02a7")) >> (modules '((guix build utils))) >> ;; Remove bundled dependencies in favour of proper inputs. >> (snippet '(for-each delete-file-recursively >> @@ -244,7 +244,12 @@ communication.") >> ("openssl" ,openssl) >> ("tinyxml2" ,tinyxml2))) >> (arguments >> - `(#:configure-flags (list "-DUSE_INTERNAL_TINYXML=3DOFF"))) >> + `(#:configure-flags (list "-DUSE_INTERNAL_TINYXML=3DOFF") >> + #:phases >> + (modify-phases %standard-phases >> + (add-before 'check 'make-unittests >> + (lambda _ >> + (zero? (system* "make" "unittests"))))))) > > Any particular reason you decided to use '(zero? (system* ...))' rather > than '(invoke ...)' for this phase? I tried it with 'invoke' and it > worked fine. > >> (home-page "https://vgough.github.io/encfs") >> (synopsis "Encrypted virtual file system") >> (description > > Other than the above, this patch looks good! :) Also, do note that the snippet needs to be updated, as bundled libraries (now including googletest) have moved to the "vendor" subdirectory. Once you remove the "vendor" subdirectory, you may have to add 'googletest' from '(gnu packages check)' to the native-inputs. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlsig/4ACgkQ5qXuPBlG eg1GbhAAwqjrg0lBqnGLLNldZ0bGd0bkBwxrrSnqUKJeEWVXnurF88pHNwvJOx6+ z+yHPNsPW6T3rsE/LsEwFQc2p6GpeFIcS16tII0UCpnQhszb2lyHIp6eweDBY5gF fJxgUPORAukKIz9GWkYDSdMMJUwydcykYUKTakfY0g3ZKpA/mNDZZj46mCEwFPsC ASH1iWw5cvABI8vWnz7u9UnZVgtv/0yMpuj5UTgPJf+2hZvUyDEcdgeKEG9yFySZ IrzDHhW3rFZQOK6WoTwOkoec58EdU9ApKssu7A+q69v4jZaPdXs2I54fZ8xD7TpY GTT1Hu0zE7cgksLbP419qXYa19BG0/Lcsp998Kdj6oZDP9AIajqeEWn4UwHJwfEJ kKfplI7ouZYZHxAUsfQ1zljQeN41pNkFLWM1fUtOCFHEYIcpUebO9zhndnEIUS5h MEKNSuOKQTl/UmvG/KrtU1YzUhkGYqp7Ovz7sBqBaPJplh18Y26yaoQtsrijZHeK BH3NkLGKKZXZWcgEoutyn6yf3e6MyETcMYFwlmDOHBcf5DNrZ/SQkLykDu3BZ4IE g8kYvpNurrqcDDcKNe/p3TMBk7OEWyxvE6mc4cKN5rxMOV6l9nVDZjkJ8pxVV2Du olIF82y0iJoM5izgpyH+Jlra7Yj2Ld0tJ4Ha6sXwcvEINFLwPaE= =ramM -----END PGP SIGNATURE----- --=-=-=--