From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fg5Qn-00006A-FT
	for guix-patches@gnu.org; Thu, 19 Jul 2018 05:41:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fg5Qk-0004m1-E3
	for guix-patches@gnu.org; Thu, 19 Jul 2018 05:41:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42497)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fg5Qk-0004lo-8J
	for guix-patches@gnu.org; Thu, 19 Jul 2018 05:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fg5Qj-0001a9-Ju
	for guix-patches@gnu.org; Thu, 19 Jul 2018 05:41:02 -0400
Subject: [bug#32141] [PATCH] services: Add ddclient service.
Resent-Message-ID: <handler.32141.B32141.15319932496054@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180713145854.12250-1-go.wigust@gmail.com>
Date: Thu, 19 Jul 2018 11:40:36 +0200
In-Reply-To: <20180713145854.12250-1-go.wigust@gmail.com> (Oleg Pykhalov's
	message of "Fri, 13 Jul 2018 17:58:54 +0300")
Message-ID: <87lga7wokr.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 32141@debbugs.gnu.org

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/services/dns.scm (ddclient-configuration, opaque-ddclient-configura=
tion,
> ddclient-service-type): New variables.
> (uglify-field-name, serialize-field, serialize-boolean, serialize-integer,
> serialize-string, serialize-list, serialize-extra-options,
> ddclient-activation, ddclient-shepherd-service,
> generate-ddclient-documentation, generate-opaque-ddclient-documentation):=
 New
> procedures.
> * doc/guix.texi (DNS Services): Document it.

[...]

> +@subsubheading ddclient Service
> +
> +@cindex ddclient
> +@uref{https://sourceforge.net/projects/ddclient/, ddclient} is an address
> +updating utility for dynamic DNS services.

It would be nice to expound a bit, like:

  The ddclient service described below runs the ddclient daemon, which
  takes care of automatically updating DNS entries for service providers
  such as DynDNS.com.

Also, is there a better home page?

Otherwise LGTM!

> +    (list (shepherd-service
> +           (provision '(ddclient))
> +           (documentation "Run ddclient daemon.")
> +           (start #~(make-forkexec-constructor
> +                     (list #$(file-append ddclient "/bin/ddclient")
> +                           "-foreground" "-file" "/etc/ddclient/ddclient=
.conf"
> +                           "-debug" "-verbose")
> +                     #:pid-file #$pid
> +                     #:environment-variables
> +                     (list "SSL_CERT_DIR=3D/run/current-system/profile\
> +/etc/ssl/certs"
> +                           "SSL_CERT_FILE=3D/run/current-system/profile\
> +/etc/ssl/certs/ca-certificates.crt")))
> +           (stop #~(make-kill-destructor))))))

Does it run as root?  If there=E2=80=99s no option to run it (mostly) as
non-root, perhaps it would make sense to try using
=E2=80=98make-forkexec-constructor/container=E2=80=99 here (as a separate p=
atch.)

WDYT?

Thank you,
Ludo=E2=80=99.