From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42001)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqSM-00082E-VI
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:07:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqSE-0005N5-SA
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:07:14 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50902)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1frqS6-0005Ia-5I
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:07:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqS5-00028Y-VY
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:07:02 -0400
Subject: [bug#32346] [PATCH 4/6] marionette: Add wait-for-unix-socket.
Resent-Message-ID: <handler.32346.B32346.15347955628124@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180802064520.20273-1-cmmarusich@gmail.com>
	<20180802065159.20413-1-cmmarusich@gmail.com>
	<20180802065159.20413-4-cmmarusich@gmail.com>
Date: Mon, 20 Aug 2018 22:05:47 +0200
In-Reply-To: <20180802065159.20413-4-cmmarusich@gmail.com> (Chris Marusich's
	message of "Wed, 1 Aug 2018 23:51:57 -0700")
Message-ID: <87lg90dcro.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 32346@debbugs.gnu.org

Chris Marusich <cmmarusich@gmail.com> skribis:

> * gnu/build/marionette.scm (wait-for-unix-socket): New variable.

[...]

> +(define* (wait-for-unix-socket path marionette

Super nitpick: s/path/file/ or s/path/file-name/, as per GNU
convention (where =E2=80=9Cpath=E2=80=9D means =E2=80=9Csearch path=E2=80=
=9D.)

Otherwise LGTM!

Ludo=E2=80=99.