From: "Clément Lassieur" <clement@lassieur.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 32869-done@debbugs.gnu.org
Subject: bug#32869: [PATCH cuirass] Provide link to build log in build table row.
Date: Sat, 29 Sep 2018 13:37:28 +0200 [thread overview]
Message-ID: <87lg7ka613.fsf@lassieur.org> (raw)
In-Reply-To: <20180928221831.4425-1-dannym@scratchpost.org>
Hi Danny,
Thank you for this patch! But it doesn't work because 'href' isn't an
attribute. But don't worry about it: Tatiana already did a patch that
contains this change, I'll try to push it soon.
Cheers,
Clément
Danny Milosavljevic <dannym@scratchpost.org> writes:
> * src/cuirass/templates.scm (build-eval-table): Provide link to build log.
> ---
> src/cuirass/templates.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm
> index 7ee579c..9a7bf45 100644
> --- a/src/cuirass/templates.scm
> +++ b/src/cuirass/templates.scm
> @@ -189,7 +189,8 @@
> ""))))
> (th (@ (scope "row")),(assq-ref build #:id))
> (td ,(assq-ref build #:jobset))
> - (td ,(strftime "%c" (localtime (assq-ref build #:stoptime))))
> + (td (a (@ href "/build/" ,(assq-ref build #:id) "/log/raw")
> + ,(strftime "%c" (localtime (assq-ref build #:stoptime)))))
> (td ,(assq-ref build #:job))
> (td ,(assq-ref build #:nixname))
> (td ,(assq-ref build #:system))))
prev parent reply other threads:[~2018-09-29 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 22:18 [bug#32869] [PATCH cuirass] Provide link to build log in build table row Danny Milosavljevic
2018-09-29 11:37 ` Clément Lassieur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg7ka613.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=32869-done@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.