From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 33286@debbugs.gnu.org
Subject: [bug#33286] Add 'list-formats' to 'guix pack'
Date: Tue, 06 Nov 2018 16:31:59 +0100 [thread overview]
Message-ID: <87lg66xlw0.fsf@gnu.org> (raw)
In-Reply-To: <20181106095316.GB1206@macbook41> (Efraim Flashner's message of "Tue, 6 Nov 2018 11:53:16 +0200")
Hello,
Efraim Flashner <efraim@flashner.co.il> skribis:
> From af9a132a662f1d703df1c32278a45d2adca146ed Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue, 6 Nov 2018 11:50:48 +0200
> Subject: [PATCH] pack: List the available formats.
>
> * guix/scripts/pack.scm (show-formats): New variable.
> (%options, show-help): Add 'list-formats' option.
[...]
> @@ -551,6 +552,18 @@ please email '~a'~%")
> (squashfs . ,squashfs-image)
> (docker . ,docker-image)))
>
> +(define (show-formats)
> + ;; Print the supported pack formats.
> + (display (G_ "The supported formats for 'guix pack' are:"))
> + (newline)
> + (display (G_ "
> + tarball A self-contained tarball, ready to run on another machine."))
> + (display (G_ "
> + squashfs A squashfs image, ready for 'cluster engines' and the like."))
I’d write “Squashfs image suitable for Singularity” and remove “A” from
each.
Also, since we have the ‘%formats’ alist right above, what about
adjusting it so that it contains each format description, and then
‘show-formats’ would just traverse it?
You could do:
(define-record-type <image-format>
(image-format proc description)
image-format?
(proc image-format-procedure)
(description image-format-description))
(define %formats
(let-syntax ((description (syntax-rules () ((_ str) str))))
`((tarball . ,(image-format self-contained-tarball
(description "foo bar")))
…)))
The dummy ‘description’ macro is here to allow ‘xgettext’ to catch the
translatable strings without actually translating them right away;
‘show-formats’ will have to call ‘G_’ for that.
WDYT?
Ludo’.
next prev parent reply other threads:[~2018-11-06 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 9:53 [bug#33286] Add 'list-formats' to 'guix pack' Efraim Flashner
2018-11-06 10:39 ` Danny Milosavljevic
2018-11-06 10:48 ` Efraim Flashner
2018-11-06 15:31 ` Ludovic Courtès [this message]
2018-11-27 17:26 ` Efraim Flashner
2021-07-13 12:03 ` bug#33286: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg66xlw0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33286@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.