From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in master? Date: Fri, 23 Nov 2018 14:49:35 +0100 Message-ID: <87lg5j6h00.fsf@gnu.org> References: <87lg6sejwa.fsf@gmail.com> <87wopd88hq.fsf@gmail.com> <877ehcsocq.fsf@gnu.org> <87bm6oxsyf.fsf@gmail.com> <87a7m7yhu5.fsf@gmail.com> <878t1rygfu.fsf@gmail.com> <877ehbydmz.fsf@gmail.com> <87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com> <87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com> <87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQBq6-0005JI-Dt for guix-devel@gnu.org; Fri, 23 Nov 2018 08:49:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQBq5-0007CQ-Ju for guix-devel@gnu.org; Fri, 23 Nov 2018 08:49:46 -0500 In-Reply-To: <875zwp17od.fsf@gmail.com> (Mathieu Othacehe's message of "Thu, 22 Nov 2018 23:57:38 +0900") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: Guix-devel Hello! Mathieu Othacehe skribis: >> If you add it to /etc/environment (through >> =E2=80=98session-environment-service-type=E2=80=99) it should be fine no? > > LANG is already part of /etc/environment variables which are loaded by > the login program which is PAM aware. The installer isn't PAM aware and > it replaces the login program thus LANG is never loaded. Oh, got it. Now, why does the default value of LANG matter anyway? I mean, the installer starts out with a default language, presumably English, right? So you can simply add, say, (setenv "LC_ALL" "en_US.utf8") when starting the installer, can=E2=80=99t you? >> 1. ./configure and (guix self) are adjusted to not build the >> installer, at least by default. >> >> 2. The =E2=80=9Cold=E2=80=9D installation method remains prominently a= vailable, either >> by making it clear people can use ctrl-alt-f2 & co. to switch to a >> terminal, and maybe adding a message on the welcome page stating >> that the installer is =E2=80=9Cbeta=E2=80=9D or something. >> >> 3. The manual is updated to at least mention the new installer, maybe >> not in detail. Also: 4. The installation system tests still work (e.g., =E2=80=9Cmake check-system TESTS=3Dinstalled-os=E2=80=9D.) Normally t= hey won=E2=80=99t require any modifications since they just run a Bash installation script directly through the marionette. >> How does that sound? > > I agree it would be great :), I'm currently focusing on parted support > but, I'll shift to the 3 points you described above so that it can be > merged on time. Awesome. When do you think we could merge? I=E2=80=99d like to release by the end of next week or the week after at the latest. (If you think you can=E2=80=99t= make it, that=E2=80=99s fine too, no pressure!) Thanks! Ludo=E2=80=99.