From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gor5y-0000ir-EC for guix-patches@gnu.org; Wed, 30 Jan 2019 09:44:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gor5x-0002wg-HX for guix-patches@gnu.org; Wed, 30 Jan 2019 09:44:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gor5u-0002vd-IE for guix-patches@gnu.org; Wed, 30 Jan 2019 09:44:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gor5u-00052o-8V for guix-patches@gnu.org; Wed, 30 Jan 2019 09:44:02 -0500 Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba. Resent-Message-ID: References: <87zhrmgy0x.fsf@cbaines.net> <20190127114956.26570-1-mail@cbaines.net> <20190127114956.26570-11-mail@cbaines.net> From: Ricardo Wurmus In-reply-to: Date: Wed, 30 Jan 2019 13:56:08 +0100 Message-ID: <87lg32nw2f.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: swedebugia Cc: 34217@debbugs.gnu.org Hi swedebugia, > On 2019-01-27 12:49, Christopher Baines wrote: >> These packages are mutually dependant, so I've put them in one commit. >>=20 >> * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables. [=E2=80=A6] >> +(define-public ruby-aruba >> + (package >> + (name "ruby-aruba") >> + (version "0.14.7") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (rubygems-uri "aruba" version)) >> + (sha256 >> + (base32 >> + "0x27352n15dsyf5ak246znfawbrm502q15r4msjw3cis17jlcy1l")))) >> + (build-system ruby-build-system) >> + (arguments >> + '(;; TODO: There are a few test failures >> + ;; 357 examples, 7 failures > > I investigated this and found: > Failed examples: > > rspec ./spec/aruba/api_spec.rb:389 # Aruba::Api files #touch when=20 > directory when exist and the mtim\ > e should be set statically > rspec ./spec/aruba/api_spec.rb:388 # Aruba::Api files #touch when=20 > directory when exist and the mtim\ > e should be set statically behaves like an existing directory > rspec ./spec/aruba/api_spec.rb:362 # Aruba::Api files #touch when file=20 > when does not exist and the \ > mtime should be set statically > rspec ./spec/aruba/api_spec.rb:361 # Aruba::Api files #touch when file=20 > when does not exist and the \ > mtime should be set statically behaves like an existing file > rspec ./spec/aruba/matchers/command_spec.rb:165 # Command Matchers=20 > #to_have_output_on_stderr when h\ > ave output hello world on stderr > ave output hello world on stderr > rspec ./spec/aruba/matchers/command_spec.rb:128 # Command Matchers=20 > #to_have_output_on_stdout when h\ > ave output hello world on stderr > rspec ./spec/aruba/matchers/command_spec.rb:91 # Command Matchers=20 > #to_have_output when have output \ > hello world on stderr What does this mean? > The offending lines are in spec/aruba/api_spec.rb > beginning on line: 321, ending on 393 > I tried creating a patch with diff for this file. I don't know if this=20 > is the way others here usually create patches. > > If not please enlighten me! :) We usually use =E2=80=9Cdiff -u=E2=80=9D to generate patches in unified dif= f format (that=E2=80=99s the one with plus and minus prefixes). Your patch only disables the test. I would rather like to know why it fails and then fix the problem at the root. Have you figured out why they fail and how the failure can be prevented? --=20 Ricardo