From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0uuP-00036R-KR for guix-patches@gnu.org; Mon, 04 Mar 2019 16:14:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0uoc-0001Nd-Pq for guix-patches@gnu.org; Mon, 04 Mar 2019 16:08:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46739) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0uoc-0001NL-Jk for guix-patches@gnu.org; Mon, 04 Mar 2019 16:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h0uoc-0000EH-98 for guix-patches@gnu.org; Mon, 04 Mar 2019 16:08:02 -0500 Subject: [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Resent-Message-ID: References: <20190225151705.17655-1-mail@ambrevar.xyz> <871s3vq4fw.fsf@ambrevar.xyz> <87zhqjfzvv.fsf@cbaines.net> <87ftsa24ts.fsf@ambrevar.xyz> <87r2brg5z8.fsf@ambrevar.xyz> From: Christopher Baines In-reply-to: <87r2brg5z8.fsf@ambrevar.xyz> Date: Mon, 04 Mar 2019 21:06:56 +0000 Message-ID: <87lg1ufixb.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 34650@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > I've eventually figured that many of the dep requirements in the Ruby community > follow poor practices, so I've lifter all of them to ">=" and Mailcatcher seems > to work smoothly still (it starts at least). > > I've cleanup up the packages, only the tests are missing. The rest should be > ready for merge. > > Christopher, feel free to merge. Only ruby-tilt conflicts with your patch. I've now merged some of the Ruby patches that I was working on, including ruby-tilt. It would be good if you could rebase your patches on top of master, and check if they still work. I also ran guix lint on the packages and got the following warnings: gnu/packages/ruby.scm:8431:2: ruby-thin@1.7.2: line 8453 is way too long (91 characters) gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: can be upgraded to 0.7.1 gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: line 8510 is way too long (92 characters) gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: line 8514: parentheses feel lonely, move to the previous or next line gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: line 8530 is way too long (96 characters) I'll have a look at the individual patches as well. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlx9k3BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeZ3A/+LyI2+6/mqXXIKi/Tez3MhVTH5ezEe69/h5uZCzXtP115b4QIukyqcn0A v5MRV80FNSNycpHmUgxsFUNuYEOYBmXn9lpYSz4bOPvgwG5Dkf2DylSmR1jmxojF Y6mJGm9+PvyCdqwKyza3EW0BEH7d8E6yYo/7+qbrWMJDlLQG2GGHs2KEUE75mApa 3NtNTUIgIfzCgHFPmIWGBSH7nm3vRcvN9sXBk6FoTZI1+HSGiPqe24udvp+mgFY8 wkcVuiFVbGiiYEidvpuM42DHWBhKlQbEkITqDmBJiCHPlJJS+2s20BPR7GSEKp8L wHTeXX0MXJyDFnS0O3pnceU7XsCm5ruZXrUYDOHPIhJrz67NrO8OPoq17YtUMaPC hug/AF37w1eCyxuSGVbF8fpyjhykrP7eiQVQUSISr99QbS+KD8HQEWjNngqMO0tM UuB3hpsP9NYLlp/GrQjRcj6VsY2xf1QsE8sxmKcVdebo8KizjOF60ZozgbFSAKgA u4dB10SLRpu2u67TpNiQ5kBQx4OAYDkr/87LEjtUIyxuJZXdefi30sVFbds0Z8ls U6zPfpe/uJ1LGnr70QDofN+xngazkTAAwf6Z1UL8XcDOmjr6bFPV0CuNuF0BYnCg N/aLGG5B9QN4LewBvTx2c9B8HBDPuSAR71r5JtI4h9ijpF5R30s= =42Qp -----END PGP SIGNATURE----- --=-=-=--