all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34650@debbugs.gnu.org
Subject: [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft)
Date: Mon, 04 Mar 2019 21:06:56 +0000	[thread overview]
Message-ID: <87lg1ufixb.fsf@cbaines.net> (raw)
In-Reply-To: <87r2brg5z8.fsf@ambrevar.xyz>

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]


Pierre Neidhardt <mail@ambrevar.xyz> writes:

> I've eventually figured that many of the dep requirements in the Ruby community
> follow poor practices, so I've lifter all of them to ">=" and Mailcatcher seems
> to work smoothly still (it starts at least).
>
> I've cleanup up the packages, only the tests are missing.  The rest should be
> ready for merge.
>
> Christopher, feel free to merge.  Only ruby-tilt conflicts with your patch.

I've now merged some of the Ruby patches that I was working on,
including ruby-tilt. It would be good if you could rebase your patches
on top of master, and check if they still work.

I also ran guix lint on the packages and got the following warnings:

gnu/packages/ruby.scm:8431:2: ruby-thin@1.7.2: line 8453 is way too long (91 characters)
gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: can be upgraded to 0.7.1
gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: line 8510 is way too long (92 characters)
gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: line 8514: parentheses feel lonely, move to the previous or next line
gnu/packages/ruby.scm:8491:2: mailcatcher@0.6.5: line 8530 is way too long (96 characters)

I'll have a look at the individual patches as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2019-03-04 21:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 15:17 [bug#34650] [PATCH] ruby-mailcatcher: Draft Pierre Neidhardt
     [not found] ` <handler.34650.B.155110784318701.ack@debbugs.gnu.org>
2019-02-25 15:21   ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-02-25 19:10     ` Christopher Baines
2019-02-26 10:59       ` Pierre Neidhardt
2019-02-28 17:44         ` [bug#34650] [PATCH 1/7] gnu: ruby-rack-protection: Update to 2.0.5 Pierre Neidhardt
2019-02-28 17:44           ` [bug#34650] [PATCH 2/7] gnu: Add ruby-tilt Pierre Neidhardt
2019-02-28 17:44           ` [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann Pierre Neidhardt
2019-03-04 21:20             ` Christopher Baines
2019-02-28 17:44           ` [bug#34650] [PATCH 4/7] gnu: Add ruby-sinatra Pierre Neidhardt
2019-02-28 17:44           ` [bug#34650] [PATCH 5/7] gnu: Add ruby-thin Pierre Neidhardt
2019-03-04 21:33             ` Christopher Baines
2019-02-28 17:44           ` [bug#34650] [PATCH 6/7] gnu: Add ruby-skinny Pierre Neidhardt
2019-03-04 21:43             ` Christopher Baines
2019-02-28 17:44           ` [bug#34650] [PATCH 7/7] gnu: Add mailcatcher Pierre Neidhardt
2019-03-04 21:50             ` Christopher Baines
2019-03-05  9:09               ` Pierre Neidhardt
2019-03-05 10:27                 ` Pierre Neidhardt
2019-03-05 18:51                 ` Christopher Baines
2019-02-28 17:47         ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-03-04 21:06           ` Christopher Baines [this message]
2019-03-05  9:18             ` Pierre Neidhardt
2019-03-05 18:51               ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg1ufixb.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=34650@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.