From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDPgK-0007ZW-EB for guix-patches@gnu.org; Mon, 08 Apr 2019 04:31:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDPgE-0000eo-Tb for guix-patches@gnu.org; Mon, 08 Apr 2019 04:31:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDPgE-0000ee-MG for guix-patches@gnu.org; Mon, 08 Apr 2019 04:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDPgE-00088G-H8 for guix-patches@gnu.org; Mon, 08 Apr 2019 04:31:02 -0400 Subject: bug#35033: [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190328200054.8306-1-eisenmann@fn.de> <87imvurg5v.fsf@gnu.org> <20190404004834.454c6be1@fn.de> Date: Mon, 08 Apr 2019 10:29:54 +0200 In-Reply-To: <20190404004834.454c6be1@fn.de> (Timo Eisenmann's message of "Thu, 4 Apr 2019 00:48:34 +0200") Message-ID: <87lg0k2931.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Timo Eisenmann Cc: 35033-done@debbugs.gnu.org Hello, Timo Eisenmann skribis: > On Wed, 03 Apr 2019 22:24:12 +0200 > Ludovic Court=C3=A8s wrote: [...] >> I think it=E2=80=99s a case where it may be more appropriate to look for >> =E2=80=98youtube-dl=E2=80=99 in $PATH because =E2=80=98youtube-dl=E2=80= =99 is updated frequently. >>=20 >> WDYT? > > I think we should make mpv's youtube-dl feature work by default instead > of requiring the user to install youtube-dl into their profile. Arun Isaac skribis: > We normally don't require the user to install dependencies such as > youtube-dl into the profile. I think we should retain that behaviour > even in this case with mpv. It would mean fewer surprises for the > user. If I'm guessing correctly, mpv doesn't require a lot of effort to > rebuild. Alright, that makes sense (and indeed, mpv builds very quickly.) I added a #t at the end of the phase and committed. Thank you! Ludo=E2=80=99.