From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUCCm-0008Hw-Nv for guix-patches@gnu.org; Fri, 24 May 2019 11:34:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUC8x-0000TM-PG for guix-patches@gnu.org; Fri, 24 May 2019 11:30:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33524) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUC8x-0000T0-BZ for guix-patches@gnu.org; Fri, 24 May 2019 11:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUC8x-0007m9-6E for guix-patches@gnu.org; Fri, 24 May 2019 11:30:03 -0400 Subject: [bug#35741] [PATCH] gnu: Add libdbusmenu. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190515045127.30916-1-meiyo@riseup.net> <87tvdoom3i.fsf@gnu.org> <877eaix6z5.fsf@riseup.net> Date: Fri, 24 May 2019 17:29:26 +0200 In-Reply-To: <877eaix6z5.fsf@riseup.net> (Meiyo Peng's message of "Thu, 23 May 2019 10:03:26 +0800") Message-ID: <87lfyvx44p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Meiyo Peng Cc: 35741-done@debbugs.gnu.org Hello, Meiyo Peng skribis: >>> + ;; The shebang of the generated test files should be patched = before >>> + ;; enabling tests. >>> + "--disable-tests") >> >> It would be nice if you could follow up with a patch to run the tests. > > Will try. Great. > libdbusmenu-glib, libdbusmenu-gtk, and some files in tools are dual > licensed under LGPLv2.1 and LGPLv3. The rest files are licensed under > GPLv3. For example: > > #+begin_example > https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/vie= w/head:/tests/json-loader.c > https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/vie= w/head:/tools/dbusmenu-dumper.c > #+end_example > > So we should clarify it further. I=E2=80=99d argue that =E2=80=98license=E2=80=99 is about the license of wh= at we install, so the license of the tests or build scripts (say) doesn=E2=80=99t matter much, but =E2=80=98dbusmenu-dumper=E2=80=99 is presumably something we install. So I= agree: further clarification is welcome! Thanks for explaining, Ludo=E2=80=99.