From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:59191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hVMdB-00081I-5I
	for guix-patches@gnu.org; Mon, 27 May 2019 16:54:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hVMdA-0006sH-6j
	for guix-patches@gnu.org; Mon, 27 May 2019 16:54:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40764)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hVMdA-0006s0-3m
	for guix-patches@gnu.org; Mon, 27 May 2019 16:54:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hVMdA-0003Pu-0h
	for guix-patches@gnu.org; Mon, 27 May 2019 16:54:04 -0400
Subject: bug#35880: [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed'.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35880.D35880.155899040313077.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190524134238.22802-1-ludo@gnu.org>
	<87d0k6o3am.fsf@ambrevar.xyz> <87ftp1m1te.fsf@gnu.org>
	<87blznsxym.fsf@gnu.org> <87ef4jlvbr.fsf@ambrevar.xyz>
Date: Mon, 27 May 2019 22:53:11 +0200
In-Reply-To: <87ef4jlvbr.fsf@ambrevar.xyz> (Pierre Neidhardt's message of
	"Mon, 27 May 2019 18:24:08 +0200")
Message-ID: <87lfyrr554.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 35880-done@debbugs.gnu.org

Hi!

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> That said, if the encoder buffer is not empty, I think lz-compress-read
> should always return something >0.

Yes, probably.  The docstring for =E2=80=98lz-compress-read=E2=80=99 says:

    "Read up to COUNT bytes from the encoder stream, storing the results in=
 LZFILE-BV.
  Return the number of uncompressed bytes written, a strictly positive inte=
ger."
                                                     ^~~~~~~~~~~~~~~~~

However, the lzlib manual doesn=E2=80=99t say that for =E2=80=98LZ_compress=
_read=E2=80=99 (info
"(lzlib) Compression functions").

But that=E2=80=99s OK: the =E2=80=98read!=E2=80=99 method in =E2=80=98make-=
lzip-input-port/compressed=E2=80=99
can just call =E2=80=98lzwrite!=E2=80=99 again with more data when that hap=
pens, so I=E2=80=99ve
done that.

And I pushed the whole thing! :-)

I think it=E2=80=99d be good to let people play with it in their personal
setups.

Next up: multi-compression support in =E2=80=98guix publish=E2=80=99 (possi=
bly?) so we
can smoothly transition on our build farms.

Thanks!

Ludo=E2=80=99.