From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36706) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hk74J-0006yI-I0 for guix-patches@gnu.org; Sun, 07 Jul 2019 09:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hk74I-00029P-Cp for guix-patches@gnu.org; Sun, 07 Jul 2019 09:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hk74I-000291-48 for guix-patches@gnu.org; Sun, 07 Jul 2019 09:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hk74H-0004Ea-UO for guix-patches@gnu.org; Sun, 07 Jul 2019 09:19:01 -0400 Subject: [bug#30254] [bug#30256] [PATCH 3/3] scripts: environment: Add --no-cwd. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <7bc71eaa3cff48ec7dc0d4fe406dde9482b716a9.1516937216.git.mtg@gnu.org> Date: Sun, 07 Jul 2019 15:18:20 +0200 In-Reply-To: (Carl Dong's message of "Sat, 29 Jun 2019 23:27:43 +0000") Message-ID: <87lfxac7ab.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Carl Dong Cc: 30254@debbugs.gnu.org, "30256@debbugs.gnu.org" <30256@debbugs.gnu.org> --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Carl, Carl Dong skribis: > I believe I've found a solution to the problem that Ludo was encountering= . The > reason why Ludo was having trouble was because when a user specifies `--u= ser`, > we rewrite the targets of our filesystem mappings so that every instance = of > `$HOME` (as seen ouside the container) becomes `/home/$USER`. Since this = applied > to all filesystem mappings, it included our filesystem mappings for input= s too. > However, our symlinks were not updated. > > My change makes it so that we _only_ update the mappings that are either > user-specified, or cwd (if applicable). This solves Ludo's problems. > > Here's the patch, let me know if it looks good: > https://github.com/dongcarl/guix/compare/8e92d5465fc154fed5d06f7e4a64d7dc= ccded74d...2019-06-env-no-cwd-fix.patch Good catch! The patches LGTM. (Note: you can use the =E2=80=98Co-authored= -by=E2=80=99 tag for the second patch, I think it=E2=80=99s a more or less common convention.) Speaking of which, could you create an account on Savannah? That way we could grant you commit access to make it more convenient for you and so you can review and apply other people=E2=80=99s patches in your areas of ex= pertise. Please let me know what your account is, and reply with a message signed by the key you=E2=80=99ll use to sign commits. Also please read the =E2=80= =98HACKING=E2=80=99 file for info on the commit =E2=80=9Crules=E2=80=9D. Thanks! Ludo=E2=80=99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPORkVYqE/cadtAz7CQsRmT2a67UFAl0h8RwACgkQCQsRmT2a 67Xc+Q/+Kq8VHJSSLVX8lMtbCNz+PR7fjFXVIou2E81SyQ1RzjeK/Iy0RbwdsOnX 02/GB1+8WK2F4L/j+48DEAzNO9Pg3AMYNITXaCyhxx0uqjhCIgWK5XBfLnjgGGIO e2U2mxRhwCDAK5hbdlJncrtax6rgqouZmUiPkTfJ6cnJRmYAWtl/2zKf7aPxiZ/Z k9k2E4IUcsDrP/tpl6CT8WUiFOBvzudfbFij3PH7a17kzO7TQKJAK7R9R2LdywwC teZ2BYzpqF+eMo1+L13aQpC+Kh58rYDU+DWsIVtm0vnEJqLdkiOZsgIMOlIhuluN gS1RR06af/ayJsxilwS3DUjXKetVo0Dr7EaOyhSzW0UfYepHZQVQDDVu9ELJ2qu5 QaWZGcWqx+tS78JHIO3yHgWisTaB473JroKPJbvCkoDMTXrHoyEoRA9kX4IzPL5N DT+8GcXhn+iAQneZBBxemRZuxVlEMi3lqP5NMLH9bsS7Gm2hCFKCqYoBEGKhgLiQ qEDTJLVrT96f39KxItPrps40qrvPWu3U8vcxf9XIlIHM8yZ1PC44UTViH8aKmq+r YhD+RjsiyYNq2frW7U+Nv7INkyHWujmMFhmhw2rfv9cfU00+Eq/yIqu2dR3B4PiS Ubz0hngpdNh1ySpgoJq0Cgj5hyrcHd6nWsVwhda/rawJp83RWFg= =SlEi -----END PGP SIGNATURE----- --=-=-=--