From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47290)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hlwhZ-00072I-1S
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:39:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hlwhX-00074b-4n
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:39:08 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:59910)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hlwhT-0006y7-5A
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:39:05 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hlwhS-00085V-2L
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:39:02 -0400
Subject: [bug#35790] [PATCH 2/2] lint: Separate checkers by dependence on the
 internet.
Resent-Message-ID: <handler.35790.B35790.156294230931050@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87a7dyoryh.fsf@gnu.org> <20190702192542.16179-1-mail@cbaines.net>
 <20190702192542.16179-2-mail@cbaines.net>
Date: Fri, 12 Jul 2019 16:38:20 +0200
In-Reply-To: <20190702192542.16179-2-mail@cbaines.net> (Christopher Baines's
 message of "Tue, 2 Jul 2019 20:25:42 +0100")
Message-ID: <87lfx3gvxf.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35790@debbugs.gnu.org

Hi,

Christopher Baines <mail@cbaines.net> skribis:

> I think there are a couple of potential uses for this. It's somewhat a
> separation in to what checkers are just checking the contents of the
> repository (line length for example), and other checkers which are bringi=
ng in
> external information which could change.
>
> I'm thinking particularly, about treating network dependant checkers
> differently when automatically running them, but this commit also adds a
> --no-network flag to guix lint, which selects the checkers that don't acc=
ess
> the network, which could be useful if no network access is available.
>
> * guix/lint.scm (%checkers): Rename to %all-checkers.
> (%local-checkers, %network-dependant-checkers): New variables.
> * guix/scripts/lint.scm (run-checkers): Make the checkers argument mandat=
ory.
> (list-checkers-and-exit): Handle the checkers as an argument.
> (%options): Adjust for changes to %checkers, add a --no-network option, a=
nd
> change how the --list-checkers option is handled.
> (guix-lint): Adjust indentation, and update how the checkers are handled.

Nice.

> +(define %network-dependant-checkers
                          ^
Shouldn=E2=80=99t it be =E2=80=9Cdependent=E2=80=9D with an =E2=80=98e=E2=
=80=99?

Otherwise LGTM, thanks!

Ludo=E2=80=99.