From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59352)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iYppX-0005Qu-2Q
 for guix-patches@gnu.org; Sun, 24 Nov 2019 06:13:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iYppW-0003Qk-1m
 for guix-patches@gnu.org; Sun, 24 Nov 2019 06:13:26 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:49292)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iYppV-0003Qf-V0
 for guix-patches@gnu.org; Sun, 24 Nov 2019 06:13:26 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iYplJ-0001mv-KR
 for guix-patches@gnu.org; Sun, 24 Nov 2019 06:09:19 -0500
Subject: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Resent-Message-ID: <handler.38286.B38286.15745936546753@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <3dfac477-b081-49f4-86b3-2c142bb39f6b@www.fastmail.com>
 <87blt5k336.fsf@gnu.org> <20191121101755.GD15074@E5400>
 <550ee09b-7126-4acd-87ab-4e3a77cb346c@www.fastmail.com>
 <8e0a1df0-2df6-4efe-b8e5-02cf468ab8d9@www.fastmail.com>
 <cd5ab7d8-685c-48b7-be48-4545f4876528@www.fastmail.com>
Date: Sun, 24 Nov 2019 12:03:36 +0100
In-Reply-To: <cd5ab7d8-685c-48b7-be48-4545f4876528@www.fastmail.com> (Alex
 Griffin's message of "Thu, 21 Nov 2019 22:15:47 +0000")
Message-ID: <87lfs5zgc7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: 38286@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>

Hello!

"Alex Griffin" <a@ajgrf.com> skribis:

> From 41abd13973e20750815b5f395acb9fc4893c6817 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a@ajgrf.com>
> Date: Tue, 19 Nov 2019 19:59:32 -0600
> Subject: [PATCH] gnu: Add netcat-openbsd.
>
> * gnu/packages/admin.scm (netcat-openbsd): New variable.

Overall LGTM; I like that we=E2=80=99re not taking responsibility for all t=
hese
patches.  :-)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://salsa.debian.org/debian/netcat-openbsd=
.git")
> +                    (commit (string-append "debian/" version))))
> +              (sha256
> +               (base32
> +                "0j85gzbjzs6yrhgabh3zkwzd27qkr5s0zjjczl0hah8q7yhrjk3m"))=
))

I suspect =E2=80=98guix lint=E2=80=99 suggests a =E2=80=98file-name=E2=80=
=99 field here.  :-)

> +    (home-page "https://packages.debian.org/sid/netcat-openbsd")
> +    (synopsis "TCP/IP swiss army knife")

Could you make that more factual, like =E2=80=9CRead and write data over TC=
P/IP=E2=80=9D
(same as for =E2=80=98netcat=E2=80=99 actually)?

> +    (description
> +     "A simple Unix utility which reads and writes data across network
         ^
Please write full sentences.

OK to push with changes along these lines!

Thanks,
Ludo=E2=80=99.