From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Le Vaillant Subject: Re: Looking for help with packaging a Common Lisp library Date: Sat, 25 Jan 2020 19:28:46 +0100 Message-ID: <87lfpv8k69.fsf@yamatai> References: <87k15fa60q.fsf@ambrevar.xyz> <87muab8qf7.fsf@yamatai> <87h80ja4qs.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54519) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivQAw-0002et-Se for guix-devel@gnu.org; Sat, 25 Jan 2020 13:28:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivQAv-0002FF-JI for guix-devel@gnu.org; Sat, 25 Jan 2020 13:28:54 -0500 Received: from mout02.posteo.de ([185.67.36.66]:35771) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ivQAu-0002Cl-TI for guix-devel@gnu.org; Sat, 25 Jan 2020 13:28:53 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 55FD82400FF for ; Sat, 25 Jan 2020 19:28:50 +0100 (CET) In-reply-to: <87h80ja4qs.fsf@ambrevar.xyz> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Pierre Neidhardt Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable We could add all the dependencies declared in the original asd files (by 'defsystem-depends-on' and 'depends-on') to the generated asd files with the following patch: =2D-8<---------------cut here---------------start------------->8--- From=207e2009177137b3ad5831b5c42d9a4387d408bc57 Mon Sep 17 00:00:00 2001 From: Guillaume Le Vaillant Date: Sat, 25 Jan 2020 18:07:37 +0100 Subject: [PATCH] build: lisp-utils: Take defsystem dependencies into consideration. * guix/build/lisp-utils.scm (system-dependencies): Add the dependencies declared with ':defsystem-depends-on' in asd-file to the list of dependencies. =2D-- guix/build/lisp-utils.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/guix/build/lisp-utils.scm b/guix/build/lisp-utils.scm index c7a589c902..cce8047d61 100644 =2D-- a/guix/build/lisp-utils.scm +++ b/guix/build/lisp-utils.scm @@ -165,10 +165,11 @@ asdf:system-depends-on. First load the system's ASD-= FILE." (asdf:load-asd (truename ,asd-file) :name ,(normalize-string system)) (with-open-file (stream ,deps-file :direction :output) =2D (format stream =2D "~s~%" =2D (asdf:system-depends-on =2D (asdf:find-system ,system)))))) + (let* ((sys (asdf:find-system ,system)) + (deps (union (asdf:system-defsystem-depends-on sys) + (asdf:system-depends-on sys) + :test (function equal)))) + (format stream "~s~%" deps))))) =20 (dynamic-wind (lambda _ =2D-=20 2.25.0 =2D-8<---------------cut here---------------end--------------->8--- With this patch, we might need to add some inputs to a few Lisp packages, but probably not a lot of them. Do you think this patch would be a good idea, or do you see some cases where it could break something? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQkUwKxurH4Z/3KlryPP4Yfgut6mgUCXiyI3gAKCRCPP4Yfgut6 mlPUAQDN9OpTJIMCuHMw2eZ0Tw8LFs5niBX0KKl3oQZWkU2IVQD/RYzO5DT6b/m8 PlwE1iNj5yIbFWMCc4fjZWDfGyzGowY= =JFRc -----END PGP SIGNATURE----- --=-=-=--