From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35212) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1XBn-00084N-PY for guix-patches@gnu.org; Tue, 11 Feb 2020 10:11:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1XBm-0003JA-FB for guix-patches@gnu.org; Tue, 11 Feb 2020 10:11:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51384) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1XBm-0003Iv-BO for guix-patches@gnu.org; Tue, 11 Feb 2020 10:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1XBm-0002aE-7M for guix-patches@gnu.org; Tue, 11 Feb 2020 10:11:02 -0500 Subject: [bug#38546] [00/11] Update Julia, Fix precompilation, add HTTP.jl Resent-Message-ID: From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: References: <87v9qpvbyr.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87wo9ouaq5.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87d0bcly8f.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <877e1jdd62.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 11 Feb 2020 16:10:17 +0100 Message-ID: <87lfp9dusm.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 38546@debbugs.gnu.org zimoun writes: Hi, > Hi Nicol=C3=B3, > > I have seen your message on IRC. > Cool for the release 1.4. > > > Could we try to include first this 1.3 one? Then push the 1.4 if it > is already ready. > > Because then, this release will be usable "forever" (or almost ;-) > even if it is not perfect and issues are fixed with the 1.4. > I mean, once a package is inside Guix, then it becomes "easily" usable > with 'guix time-machine' and saved on Software Heritage. > Therefore, considering the big picture of Scientific Reproducibility, > it matters -- for the future to be able to travel back -- to also have > 1.3. ;-) > Ok, let's do both > I think we are almost done. From my point of view, we just need to > address (or comment) these 3 points: > > 1. >> Do you have a special motivation to rename 'llvm-patch' to 'julia-patch'? >> (I agree, it is better :-)) > Yes, because now it's not only used by llvm-julia but also by the new libunwind-julia. So calling llvm-patch a function that takes a patch from the julia repo and that is applied to a "julia module" is measleading. > > 2. >> Well, only 2 inputs are missing. Do you think it is affordable to pack >> them and so remove the commentary? >> >> --8<---------------cut here---------------start------------->8--- >> ;; FIXME: The following inputs are downloaded from upstream to allow us >> ;; to use the lightweight Julia release tarball. Ideally, these inputs >> ;; would eventually be replaced with proper Guix packages. >> ;; Find dependencies versions here: >> ;; https://raw.githubusercontent.com/JuliaLang/julia/v1.3.0/deps/Version= s.make >> --8<---------------cut here---------------end--------------->8--- > I indeed tried. The main problem is that in the Makefile there's no USE_SYSTEM_{OBJCONV/LIBWHICH}, and I didn't want to mess with the it. But yes, I think I could at least try again. > > 3. >> Otherwise, there is some issues about indentation -- I think you use >> Emacs, so check that '.dir-locals.el' is correctly setup -- double >> space for sentences in description, >> 'patch/julia-SOURCE_DATE_EPOCH-mtime.patch' should be added with the >> same commit that "Update", etc. >> I have half-corrected so I can send you these 2 v2-patches if you want t= o. :-) > > If you already fixed them, yes please send a v2 patch and I'll continue working from there. > > What do you think? > Fine for me, do we need also to debug a broken test right? > > Cheers, > simon Nicol=C3=B2