From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56256)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j4iYv-00015o-G8
 for guix-patches@gnu.org; Thu, 20 Feb 2020 04:56:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j4iYu-0007wI-18
 for guix-patches@gnu.org; Thu, 20 Feb 2020 04:56:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:37884)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j4iYs-0007tC-Oo
 for guix-patches@gnu.org; Thu, 20 Feb 2020 04:56:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j4iYs-0005Vw-Ia
 for guix-patches@gnu.org; Thu, 20 Feb 2020 04:56:02 -0500
Subject: [bug#37305] Allow booting from a Btrfs subvolume [review part 2]
Resent-Message-ID: <handler.37305.B37305.158219252021145@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <875zg2xtsb.fsf@gmail.com>
Date: Thu, 20 Feb 2020 10:55:05 +0100
In-Reply-To: <875zg2xtsb.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 18
 Feb 2020 21:52:24 -0500 (15 hours, 38 minutes, 5 seconds ago)")
Message-ID: <87lfoxbn2e.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 37305@debbugs.gnu.org

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>>> +              (error "The store is on a Btrfs subvolume, but the \
>>> +subvolume name is unknown.
>>> +Hint: Define the \"btrfs-subvolume-path\" file system property or
>>> +use the \"subvol\" Btrfs file system option."))))
>
>> Rather use =E2=80=98raise=E2=80=99 with =E2=80=98&message=E2=80=99 and =
=E2=80=98&fix-hint=E2=80=99 conditions.
>
> I tried this, but importing (guix utils) to acces &fix-hint caused the in=
it
> RAM disk to fail mysteriously:

Oh, my bad.  We should move =E2=80=98&fix-hint=E2=80=99 to (guix diagnostic=
s)
eventually.

In the meantime, I=E2=80=99d say just raise a =E2=80=98&message=E2=80=99 an=
d leave the hint as a
comment (it=E2=80=99s not supposed to be a user-facing interface).  Or mayb=
e you
could define a specific error condition type for this?

Thanks,
Ludo=E2=80=99.

PS: I=E2=80=99ll comment on the other bits ASAP!